Skip to contentSkip to conversation

ppp: change MTU on TUN device when MRU option received

PATCH In review Kristen Carlson Accardi 2 participants 2 messages Apr 22, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppp: change MTU on TUN device when MRU option received

---
 gatchat/gatppp.c  |    3 ++-
 gatchat/ppp.h     |    2 +-
 gatchat/ppp_net.c |   23 ++++++++++++++++++++---
 3 files changed, 23 insertions(+), 5 deletions(-)
gatchat/gatppp.c +2 -1
index 705a298..fc6769c 100644
@@ -411,7 +411,8 @@ void ppp_net_up_notify(GAtPPP *ppp, const char *ip,
 {
 	ppp->net = ppp_net_new(ppp);
 
-	ppp_net_set_mtu(ppp->net, ppp->mtu);
+	if (ppp_net_set_mtu(ppp->net, ppp->mtu) == FALSE)
+		g_printerr("Unable to set MTU\n");
 
 	if (ppp->connect_cb == NULL)
 		return;
gatchat/ppp.h +1 -1
index 07483a9..c7e6d24 100644
@@ -103,7 +103,7 @@ struct ppp_net *ppp_net_new(GAtPPP *ppp);
 const char *ppp_net_get_interface(struct ppp_net *net);
 void ppp_net_process_packet(struct ppp_net *net, guint8 *packet);
 void ppp_net_free(struct ppp_net *net);
-void ppp_net_set_mtu(struct ppp_net *net, guint16 mtu);
+gboolean ppp_net_set_mtu(struct ppp_net *net, guint16 mtu);
 
 /* PPP functions related to main GAtPPP object */
 void ppp_debug(GAtPPP *ppp, const char *str);
gatchat/ppp_net.c +20 -3
index c1f2eb4..b8b3355 100644
@@ -48,12 +48,29 @@ struct ppp_net {
 	gint mtu;
 };
 
-void ppp_net_set_mtu(struct ppp_net *net, guint16 mtu)
+gboolean ppp_net_set_mtu(struct ppp_net *net, guint16 mtu)
 {
-	if (net == NULL)
-		return;
+	struct ifreq ifr;
+	int sock;
+	int rc;
+
+	if (net == NULL || mtu >= MAX_PACKET)
+		return FALSE;
 
 	net->mtu = mtu;
+
+	sock = socket(AF_INET, SOCK_DGRAM, 0);
+	if (sock < 0)
+		return FALSE;
+
+	memset(&ifr, 0, sizeof(ifr));
+	strncpy(ifr.ifr_name, net->if_name, sizeof(ifr.ifr_name));
+	ifr.ifr_mtu = mtu;
+
+	rc = ioctl(sock, SIOCSIFMTU, (caddr_t) &ifr);
+
+	close(sock);
+	return (rc < 0) ? FALSE: TRUE;
 }
 
 void ppp_net_process_packet(struct ppp_net *net, guint8 *packet)
Signature · 1 line
1.6.6.1
#1 lore raw

Hi Kristen,

Quoted 5 lines
---
 gatchat/gatppp.c  |    3 ++-
 gatchat/ppp.h     |    2 +-
 gatchat/ppp_net.c |   23 ++++++++++++++++++++---
 3 files changed, 23 insertions(+), 5 deletions(-)

Patch has been applied. Thanks.

Regards,
-Denis