ehci-pci: print hccr, hcor and hc_lenght

PATCH New Florian Fainelli 2 participants 3 messages Apr 23, 2010 – Sep 12, 2010

Subsystems (2)

USB USB ehci driver

lore

Share & tools

lore

Florian Fainelli

author

2010-04-23 08:41 UTC #0 lore raw

PATCH 1/1 ehci-pci: print hccr, hcor and hc_lenght

It is useful to know the EHCI-PCI hccr, hcor and hc_lenght to make sure it was successfully registered, and at the correct location.

Signed-off-by Florian Fainelli <[email protected]>

---

drivers/usb/host/ehci-pci.c +4 -0

index 047902a..4402abb 100644
@@ -53,6 +53,10 @@ int ehci_hcd_init(void)
 	hcor = (struct ehci_hcor *)((uint32_t) hccr +
 			HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
 
+	printf("EHCI-PCI init hccr 0x%x and hcor 0x%x hc_length %d\n",
+			(uint32_t)hccr, (uint32_t)hcor,
+			(uint32_t)HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
+
 	return 0;
 }

Remy Bohmer

2010-09-12 10:01 UTC #1 lore raw

PATCH 1/1 ehci-pci: print hccr, hcor and hc_lenght

Hi Florian,

2010/4/23 Florian Fainelli <[email protected]>:

Quoted 13 lines

It is useful to know the EHCI-PCI hccr, hcor and hc_lenght to make sure it was successfully registered, and at the correct location.
Signed-off-by Florian Fainelli <[email protected]>
---
drivers/usb/host/ehci-pci.c +0 -0
index 047902a..4402abb 100644
@@ -53,6 +53,10 @@ int ehci_hcd_init(void)
? ? ? ?hcor = (struct ehci_hcor *)((uint32_t) hccr +
? ? ? ? ? ? ? ? ? ? ? ?HC_LENGTH(ehci_readl(&hccr->cr_capbase)));

Quoted 4 lines

+ ? ? ? printf("EHCI-PCI init hccr 0x%x and hcor 0x%x hc_length %d\n",
+ ? ? ? ? ? ? ? ? ? ? ? (uint32_t)hccr, (uint32_t)hcor,
+ ? ? ? ? ? ? ? ? ? ? ? (uint32_t)HC_LENGTH(ehci_readl(&hccr->cr_capbase))); +

I guess I missed this patch...
Should the 'printf' not be a 'debug' statement?

Kind regards,

Remy

Florian Fainelli

author

2010-09-12 12:24 UTC #2 lore raw

PATCH 1/1 ehci-pci: print hccr, hcor and hc_lenght

Hi Remy,

Le Sunday 12 September 2010 12:01:18, Remy Bohmer a ?crit :

Quoted 16 lines

Hi Florian,
2010/4/23 Florian Fainelli <[email protected]>:
Quoted 13 lines
It is useful to know the EHCI-PCI hccr, hcor and hc_lenght to make sure it was successfully registered, and at the correct location.
Signed-off-by Florian Fainelli <[email protected]>
---
drivers/usb/host/ehci-pci.c +0 -0
index 047902a..4402abb 100644
@@ -53,6 +53,10 @@ int ehci_hcd_init(void)
       hcor = (struct ehci_hcor *)((uint32_t) hccr +
                       HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
 

Quoted 6 lines

Quoted 4 lines
drivers/usb/host/ehci-pci.c +3 -0
+       printf("EHCI-PCI init hccr 0x%x and hcor 0x%x hc_length %d\n",
+                       (uint32_t)hccr, (uint32_t)hcor,
+                      
(uint32_t)HC_LENGTH(ehci_readl(&hccr->cr_capbase))); +
I guess I missed this patch...

No problem.

Quoted 1 line

Should the 'printf' not be a 'debug' statement?

I think so, I will respin this patch. Thanks!

Signature · 1 line

Florian