Skip to contentSkip to conversation

ocfs2/dlm: Make o2dlm domain join/leave messages KERN_NOTICE

PATCH New Sunil Mushran 2 participants 4 messages Apr 14, 2010 – Apr 23, 2010 OCFS2

lore
Share & tools
lore

Sunil Mushran

author
#0 lore raw

PATCH 1/2 ocfs2/dlm: Make o2dlm domain join/leave messages KERN_NOTICE

o2dlm join and leave messages are more than informational as they are required is debugging locking issues. This patch changes them from KERN_INFO to KERN_NOTICE.

Signed-off-by Sunil Mushran <[email protected]>
---
 fs/ocfs2/dlm/dlmdomain.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
fs/ocfs2/dlm/dlmdomain.c +3 -3
index 988c905..bcbbe56 100644
@@ -511,7 +511,7 @@ static void __dlm_print_nodes(struct dlm_ctxt *dlm)
 
 	assert_spin_locked(&dlm->spinlock);
 
-	printk(KERN_INFO "ocfs2_dlm: Nodes in domain (\"%s\"): ", dlm->name);
+	printk(KERN_NOTICE "o2dlm: Nodes in domain %s: ", dlm->name);
 
 	while ((node = find_next_bit(dlm->domain_map, O2NM_MAX_NODES,
 				     node + 1)) < O2NM_MAX_NODES) {

@@ -534,7 +534,7 @@ static int dlm_exit_domain_handler(struct o2net_msg *msg, u32 len, void *data,
 
 	node = exit_msg->node_idx;
 
-	printk(KERN_INFO "ocfs2_dlm: Node %u leaves domain %s\n", node, dlm->name);
+	printk(KERN_NOTICE "o2dlm: Node %u leaves domain %s\n", node, dlm->name);
 
 	spin_lock(&dlm->spinlock);
 	clear_bit(node, dlm->domain_map);

@@ -904,7 +904,7 @@ static int dlm_assert_joined_handler(struct o2net_msg *msg, u32 len, void *data,
 		set_bit(assert->node_idx, dlm->domain_map);
 		__dlm_set_joining_node(dlm, DLM_LOCK_RES_OWNER_UNKNOWN);
 
-		printk(KERN_INFO "ocfs2_dlm: Node %u joins domain %s\n",
+		printk(KERN_NOTICE "o2dlm: Node %u joins domain %s\n",
 		       assert->node_idx, dlm->name);
 		__dlm_print_nodes(dlm);
Signature · 1 line
1.6.3.3
author
#1 lore raw

PATCH 2/2 ocfs2: Make nointr a default mount option

OCFS2 has never really supported intr. This patch acknowledges this reality and makes nointr the default mount option. In a later patch, we intend to support intr.

Signed-off-by Sunil Mushran <[email protected]>
---
 fs/ocfs2/super.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
fs/ocfs2/super.c +1 -0
index dee0319..1a945ba 100644
@@ -1290,6 +1290,7 @@ static int ocfs2_parse_options(struct super_block *sb,
 	mopt->slot = OCFS2_INVALID_SLOT;
 	mopt->localalloc_opt = OCFS2_DEFAULT_LOCAL_ALLOC_SIZE;
 	mopt->cluster_stack[0] = '\0';
+	mopt->mount_opt |= OCFS2_MOUNT_NOINTR;
 
 	if (!options) {
 		status = 1;
Signature · 1 line
1.6.3.3
#2 lore raw

PATCH 2/2 ocfs2: Make nointr a default mount option

Quoted 5 lines · Sunil Mushran

OCFS2 has never really supported intr. This patch acknowledges this reality and makes nointr the default mount option. In a later patch, we intend to support intr.

Signed-off-by Sunil Mushran <[email protected]>

A modified version of this patch is now in the 'merge-window'
branch of ocfs2.git.

Joel

Signature · 9 lines
"Any man who is under 30, and is not a liberal, has not heart;
 and any man who is over 30, and is not a conservative, has no brains."
         - Sir Winston Churchill 

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
#3 lore raw

PATCH 1/2 ocfs2/dlm: Make o2dlm domain join/leave messages KERN_NOTICE

In reply to Sunil Mushran
Quoted 4 lines · Sunil Mushran

o2dlm join and leave messages are more than informational as they are required is debugging locking issues. This patch changes them from KERN_INFO to KERN_NOTICE.

Signed-off-by Sunil Mushran <[email protected]>

This patch is now in the merge-window branch of ocfs2.git.

Joel

Signature · 11 lines
The Graham Corollary:

	The longer a socially-moderated news website exists, the
	probability of an old Paul Graham link appearing at the top
	approaches certainty.

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127