Skip to contentSkip to conversation

pata_scc: kill useless check in scc_postreset()

PATCH In review Sergei Shtylyov 1 participant 1 message Apr 24, 2010 libata

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 pata_scc: kill useless check in scc_postreset()

The device control register exists and its address is set by scc_setup_ports(), hence the check is useless...

---
The patch is against the recent Linus' tree.

 drivers/ata/pata_scc.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/ata/pata_scc.c +1 -2
Index: linux-2.6/drivers/ata/pata_scc.c
===================================================================
@@ -903,8 +903,7 @@ static void scc_postreset(struct ata_lin
 	}
 
 	/* set up device control */
-	if (ap->ioaddr.ctl_addr)
-		out_be32(ap->ioaddr.ctl_addr, ap->ctl);
+	out_be32(ap->ioaddr.ctl_addr, ap->ctl);
 
 	DPRINTK("EXIT\n");
 }