ixgbe: cleanup ethtool autoneg input

From: Don Skidmore <[email protected]>

The way we were setting autoneg via ethtool was inconstant with that of our other drivers. It will change the following:

If autoneg is off:

Pause parameters for eth0:

Autonegotiate:  off
RX:             off
TX:             off

Before:

Pause parameters for eth0:

Autonegotiate:  off
RX:             off
TX:             off

Now:

Pause parameters for eth0:

Autonegotiate:  on
RX:             on
TX:             on

---

 drivers/net/ixgbe/ixgbe_ethtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

index 8f461d5..7b391f9 100644
@@ -365,7 +365,7 @@ static int ixgbe_set_pauseparam(struct net_device *netdev,
 	else
 		fc.disable_fc_autoneg = false;
 
-	if (pause->rx_pause && pause->tx_pause)
+	if ((pause->rx_pause && pause->tx_pause) || pause->autoneg)
 		fc.requested_mode = ixgbe_fc_full;
 	else if (pause->rx_pause && !pause->tx_pause)
 		fc.requested_mode = ixgbe_fc_rx_pause;

This is also not appropriate for net-2.6, it doesn't fix a regression in the regression list and it doesn't fix a catastropic crash or failure.

You really have to be kidding me if you thing a patch like this is fine this late in the -RC series.

You also aren't even numbering your patches, which is quite a transgression when a submission of a set of patches all to the same driver and/or files.

My apologies. My reasoning for not numbering them was that the patches were not related and not dependent upon each other.

As far as sending the the three patches un-acceptable patches this late in the -rc series, that was poor judgement on my part, sorry.

Cheers,
Jeff

From: Jeff Kirsher <[email protected]>
Date: Tue, 27 Apr 2010 13:05:25 -0700

No worries, I just pushed out the net-next-2.6 patches you sent to me so please respin these patches originally targetted to net-2.6 so I can apply them to net-next-2.6

Thanks.