ixgbe: cleanup ethtool autoneg input
Subsystems (2)
PATCH 1/1 ixgbe: cleanup ethtool autoneg input
From: Don Skidmore <[email protected]>
The way we were setting autoneg via ethtool was inconstant with that of our other drivers. It will change the following:
If autoneg is off:
Quoted 1 line
ethtool -a eth0
Pause parameters for eth0:
Autonegotiate: off RX: off TX: off
Before:
Quoted 2 lines
ethtool -A eth0 autoneg on
ethtool -a eth0
Pause parameters for eth0:
Autonegotiate: off RX: off TX: off
Now:
Quoted 2 lines
ethtool -A eth0 autoneg on
ethtool -a eth0
Pause parameters for eth0:
Autonegotiate: on RX: on TX: on
Signed-off-by Don Skidmore <[email protected]>
Signed-off-by Jeff Kirsher <[email protected]>
---
drivers/net/ixgbe/ixgbe_ethtool.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/ixgbe/ixgbe_ethtool.c +1 -1
@@ -365,7 +365,7 @@ static int ixgbe_set_pauseparam(struct net_device *netdev,else fc.disable_fc_autoneg = false; -if (pause->rx_pause && pause->tx_pause) +if ((pause->rx_pause && pause->tx_pause) || pause->autoneg) fc.requested_mode = ixgbe_fc_full;else if (pause->rx_pause && !pause->tx_pause) fc.requested_mode = ixgbe_fc_rx_pause;
From: Jeff Kirsher <[email protected]>
Date: Tue, 27 Apr 2010 14:31:06 -0700
Quoted 4 lines
From: Don Skidmore <[email protected]>
The way we were setting autoneg via ethtool was inconstant with that of our other drivers. It will change the following:
...
Quoted 2 lines
Signed-off-by Don Skidmore <[email protected]>Signed-off-by Jeff Kirsher <[email protected]>
Applied.