Skip to contentSkip to conversation

linux-next: April 27 (wireless/libertas warnings)

DISCUSSION Randy Dunlap 2 participants 2 messages Apr 27, 2010 Linux-next tree

lore
Share & tools
lore
#0 lore raw

drivers/net/wireless/libertas_tf/deb_defs.h:12:1: warning: "pr_fmt" redefined include/linux/kernel.h:376:1: warning: this is the location of the previous definition drivers/net/wireless/libertas_tf/deb_defs.h:12:1: warning: "pr_fmt" redefined include/linux/kernel.h:376:1: warning: this is the location of the previous definition

Signature · 6 lines
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw
Quoted 4 lines · Randy Dunlap

drivers/net/wireless/libertas_tf/deb_defs.h:12:1: warning: "pr_fmt" redefined include/linux/kernel.h:376:1: warning: this is the location of the previous definition drivers/net/wireless/libertas_tf/deb_defs.h:12:1: warning: "pr_fmt" redefined include/linux/kernel.h:376:1: warning: this is the location of the previous definition

Yup, just had this exchange w/ Stephen...

The problem comes from including slab.h before deb_defs.h (as done in linux-next). The version in wireless-testing avoids the warning by including the headers in the other order, but that is a bit ugly.

Does anyone know if it is OK to #undef pr_fmt before defining it in deb_defs.h?

John

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
[email protected]			might be all we have.  Be ready.