Skip to contentSkip to conversation

sunrpc: use formatting of module name in SUNRPC

PATCH In review [email protected] 2 participants 4 messages Apr 27, 2010 – Apr 28, 2010

Subsystems (3)
Networking NFS client NFS server
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 sunrpc: use formatting of module name in SUNRPC

From: Alex Riesen <[email protected]>

gcc-4.3.3 produces the warning:
"format not a string literal and no format arguments"

Signed-off-by Alex Riesen <[email protected]>
Cc Trond Myklebust <[email protected]>
Cc Chuck Lever <[email protected]>
Cc David S. Miller <[email protected]>
Acked-by Tom Talpey <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 net/sunrpc/xprt.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
net/sunrpc/xprt.c renamed from net/sunrpc/xprt.c~sunrpc-use-formatting-of-module-name-in-sunrpc +1 -4
diff -puN net/sunrpc/xprt.c~sunrpc-use-formatting-of-module-name-in-sunrpc net/sunrpc/xprt.c
@@ -165,7 +165,6 @@ EXPORT_SYMBOL_GPL(xprt_unregister_transp
 int xprt_load_transport(const char *transport_name)
 {
 	struct xprt_class *t;
-	char module_name[sizeof t->name + 5];
 	int result;
 
 	result = 0;

@@ -177,9 +176,7 @@ int xprt_load_transport(const char *tran
 		}
 	}
 	spin_unlock(&xprt_list_lock);
-	strcpy(module_name, "xprt");
-	strncat(module_name, transport_name, sizeof t->name);
-	result = request_module(module_name);
+	result = request_module("xprt%s", transport_name);
 out:
 	return result;
 }

_

#1 lore raw
Quoted 11 lines · On Tue, Apr 27, 2010 at 23:15, <[email protected]> wrote:

From: Alex Riesen <[email protected]>

gcc-4.3.3 produces the warning:
=C2=A0"format not a string literal and no format arguments"

Signed-off-by Alex Riesen <[email protected]>
Cc Trond Myklebust <[email protected]>
Cc Chuck Lever <[email protected]>
Cc David S. Miller <[email protected]>
Acked-by Tom Talpey <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
Quoted 5 lines

---

=C2=A0net/sunrpc/xprt.c | =C2=A0 =C2=A05 +---- =C2=A01 file changed, 1 insertion(+), 4 deletions(-)

This is one tough little patch... 2 years and counting...

author
#2 lore raw
Quoted 14 lines · On Wed, 28 Apr 2010 09:40:36 +0200 Alex Riesen <[email protected]> wrote:
Quoted 13 lines · On Tue, Apr 27, 2010 at 23:15, <[email protected]> wrote:

From: Alex Riesen <[email protected]>

gcc-4.3.3 produces the warning:
__"format not a string literal and no format arguments"

Signed-off-by Alex Riesen <[email protected]>
Cc Trond Myklebust <[email protected]>
Cc Chuck Lever <[email protected]>
Cc David S. Miller <[email protected]>
Acked-by Tom Talpey <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

Quoted 5 lines
Quoted 3 lines

__net/sunrpc/xprt.c | __ __5 +----
__1 file changed, 1 insertion(+), 4 deletions(-)

This is one tough little patch... 2 years and counting...

heh. I've only had it since June '09.

I'll merge it into 2.6.35-rc1.

#3 lore raw

On Wed, Apr 28, 2010 at 13:39, Andrew Morton <[email protected]=

Quoted 2 lines

wrote:
On Wed, 28 Apr 2010 09:40:36 +0200 Alex Riesen <[email protected]> w=

rote:

Quoted 10 lines
Quoted 5 lines
Quoted 3 lines

__net/sunrpc/xprt.c | __ __5 +----
__1 file changed, 1 insertion(+), 4 deletions(-)

This is one tough little patch... 2 years and counting...

heh. =C2=A0I've only had it since June '09.

I'll merge it into 2.6.35-rc1.

That's because I was overly pessimistic. gcc-4.3.3 only exists since 24 Jan, 2009.
I just have the change (and other request_module name formatting patche=
s)
in my trees already for quite some time...