Skip to contentSkip to conversation

nfsd4: fix filehandle comment

PATCH In review J. Bruce Fields 2 participants 4 messages Apr 28, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfsd4: fix filehandle comment

From: J. Bruce Fields <[email protected]>

Minor typos.

---
 include/linux/nfsd/nfsfh.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/linux/nfsd/nfsfh.h +2 -2
index 65e333a..45bb5a8 100644
@@ -40,8 +40,8 @@ struct nfs_fhbase_old {
  * This is the new flexible, extensible style NFSv2/v3 file handle.
  * by Neil Brown <neilb-YbfuJp6tym7X/[email protected]> - March 2000
  *
- * The file handle is seens as a list of 4byte words.
- * The first word contains a version number (1) and four descriptor bytes
+ * The file handle is seens as a list of four-byte words.
+ * The first word contains a version number (1) and three descriptor bytes
  * that tell how the remaining 3 variable length fields should be handled.
  * These three bytes are auth_type, fsid_type and fileid_type.
  *
Signature · 1 line
1.6.3.3
#1 lore raw
Quoted 14 lines · J. Bruce Fields

From: J. Bruce Fields<[email protected]>

Minor typos.

---
  include/linux/nfsd/nfsfh.h |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
include/linux/nfsd/nfsfh.h +0 -0
index 65e333a..45bb5a8 100644

include/linux/nfsd/nfsfh.h struct nfs_fhbase_old { · line 43

Quoted 6 lines
include/linux/nfsd/nfsfh.h +1 -2
@@ -40,8 +40,8 @@ struct nfs_fhbase_old {
   * This is the new flexible, extensible style NFSv2/v3 file handle.
   * by Neil Brown<neilb-YbfuJp6tym7X/[email protected]>  - March 2000
   *
- * The file handle is seens as a list of 4byte words.
- * The first word contains a version number (1) and four descriptor bytes
+ * The file handle is seens as a list of four-byte words.

seens? seen? sent?

Quoted 4 lines
include/linux/nfsd/nfsfh.h +1 -0
+ * The first word contains a version number (1) and three descriptor bytes
   * that tell how the remaining 3 variable length fields should be handled.
   * These three bytes are auth_type, fsid_type and fileid_type.
   *
Signature · 1 line
chuck[dot]lever[at]oracle[dot]com
#2 lore raw
Quoted 10 lines · Chuck Lever
Quoted 9 lines · J. Bruce Fields

From: J. Bruce Fields<[email protected]>

Minor typos.

---
  include/linux/nfsd/nfsfh.h |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
Quoted 13 lines

include/linux/nfsd/nfsfh.h struct nfs_fhbase_old { · line 43

Quoted 11 lines
include/linux/nfsd/nfsfh.h +1 -2
index 65e333a..45bb5a8 100644
@@ -40,8 +40,8 @@ struct nfs_fhbase_old {
   * This is the new flexible, extensible style NFSv2/v3 file handle.
   * by Neil Brown<neilb-YbfuJp6tym7X/[email protected]>  - March 2000
   *
- * The file handle is seens as a list of 4byte words.
- * The first word contains a version number (1) and four descriptor bytes
+ * The file handle is seens as a list of four-byte words.

seens? seen? sent?

Tunnel-vision, I guess. Better?:

commit 97fe4c3909cee35fa4732694c3837c35f02d7b32

Author: J. Bruce Fields <[email protected]>
Date:   Wed Apr 28 17:45:06 2010 -0400

nfsd: further comment typos

Whoops, missed some more.

include/linux/nfsd/nfsfh.h +2 -2
index 45bb5a8..80d55bb 100644
@@ -40,12 +40,12 @@ struct nfs_fhbase_old {
  * This is the new flexible, extensible style NFSv2/v3 file handle.
  * by Neil Brown <neilb-YbfuJp6tym7X/[email protected]> - March 2000
  *
- * The file handle is seens as a list of four-byte words.
+ * The file handle starts with a sequence of four-byte words.
  * The first word contains a version number (1) and three descriptor bytes
  * that tell how the remaining 3 variable length fields should be handled.
  * These three bytes are auth_type, fsid_type and fileid_type.
  *
- * All 4byte values are in host-byte-order.
+ * All four-byte values are in host-byte-order.
  *
  * The auth_type field specifies how the filehandle can be authenticated
  * This might allow a file to be confirmed to be in a writable part of a
#3 lore raw
Quoted 25 lines · J. Bruce Fields
Quoted 10 lines · Chuck Lever
Quoted 9 lines · J. Bruce Fields

From: J. Bruce Fields<[email protected]>

Minor typos.

---
   include/linux/nfsd/nfsfh.h |    4 ++--
   1 files changed, 2 insertions(+), 2 deletions(-)
Quoted 13 lines

include/linux/nfsd/nfsfh.h struct nfs_fhbase_old { · line 43

Quoted 11 lines
include/linux/nfsd/nfsfh.h +1 -2
index 65e333a..45bb5a8 100644
@@ -40,8 +40,8 @@ struct nfs_fhbase_old {
    * This is the new flexible, extensible style NFSv2/v3 file handle.
    * by Neil Brown<neilb-YbfuJp6tym7X/[email protected]>   - March 2000
    *
- * The file handle is seens as a list of 4byte words.
- * The first word contains a version number (1) and four descriptor bytes
+ * The file handle is seens as a list of four-byte words.

seens? seen? sent?

Quoted 1 line

Tunnel-vision, I guess. Better?:

Sure. Reviewed-by, I guess.

Quoted 30 lines

commit 97fe4c3909cee35fa4732694c3837c35f02d7b32

Author: J. Bruce Fields<[email protected]>
Date:   Wed Apr 28 17:45:06 2010 -0400

nfsd: further comment typos

Whoops, missed some more.

include/linux/nfsd/nfsfh.h +2 -2
index 45bb5a8..80d55bb 100644
@@ -40,12 +40,12 @@ struct nfs_fhbase_old {
   * This is the new flexible, extensible style NFSv2/v3 file handle.
   * by Neil Brown<neilb-YbfuJp6tym7X/[email protected]>  - March 2000
   *
- * The file handle is seens as a list of four-byte words.
+ * The file handle starts with a sequence of four-byte words.
   * The first word contains a version number (1) and three descriptor bytes
   * that tell how the remaining 3 variable length fields should be handled.
   * These three bytes are auth_type, fsid_type and fileid_type.
   *
- * All 4byte values are in host-byte-order.
+ * All four-byte values are in host-byte-order.
   *
   * The auth_type field specifies how the filehandle can be authenticated
   * This might allow a file to be confirmed to be in a writable part of a
Signature · 1 line
chuck[dot]lever[at]oracle[dot]com