xfstests: test extent size hints
PATCH 1/1 xfstests: test extent size hints
This is an adapted version of the reproduced in OSS BZ #874, which shows file corruption when using the extent size hint.
Geoffrey, can you say if licensing the small test program as GPLv2+ is fine so that we can add it to xfstests?
Signed-off-by Christoph Hellwig <[email protected]>
228 new file +87 -0
@@ -0,0 +1,87 @@ +#! /bin/bash +# FS QA Test No. 221 +# +# Check for file corruption when using the extent size hint on +# the normal data subvolume. +# +# http://oss.sgi.com/bugzilla/show_bug.cgi?id=874 +# +# Based on a bug report and testcase from Geoffrey Wehrman <[email protected]>. +# +#----------------------------------------------------------------------- +# Copyright (c) 2010 Christoph Hellwig. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# +#----------------------------------------------------------------------- +# +# creator [email protected] + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + rm -rf ${TDIR} +} + +trap "_cleanup ; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common.rc + +# real QA test starts here +_supported_fs generic +_supported_os Linux + +TDIR="${TEST_DIR}/t_holes" +NFILES="10" +EXTSIZE="256k" + +# Create the test directory +mkdir ${TDIR} + +# Set the test directory extsize +xfs_io -c "extsize ${EXTSIZE}" ${TDIR} + +# Create a set of holey files +echo "generating ${NFILES} files" + +for i in $(seq 0 ${NFILES}); do + $here/src/t_holes ${TDIR}/${i} +done + +# Compare the files +echo "comparing files" +errcnt=0 +j=0 +for i in $(seq 0 ${NFILES}); do + let j=$i+1 + while [ ${j} -lt ${NFILES} ] ; do + if ! cmp ${TDIR}/${i} ${TDIR}/${j} ; then + let errcnt=$errcnt+1 + fi + let j=$j+1 + done +done + +echo "got ${errcnt} errors" + +status=$errcnt +exit $status
228.out new file +4 -0
@@ -0,0 +1,4 @@ +QA output created by 228 +generating 10 files +comparing files +got 0 errors
group +1 -0
@@ -341,3 +341,4 @@ deprecated 225 auto quick 226 auto enospc 227 auto fsr +228 auto rw
src/Makefile +1 -1
@@ -10,7 +10,7 @@ TARGETS = dirstress fill fill2 getpagesi mmapcat append_reader append_writer dirperf metaperf \ devzero feature alloc fault fstest t_access_root \ godown resvtest writemod makeextents itrash rename \ - multi_open_unlink dmiperf unwritten_sync genhashnames + multi_open_unlink dmiperf unwritten_sync genhashnames t_holes LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \ preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \
src/t_holes.c new file +29 -0
@@ -0,0 +1,29 @@ + +#include <unistd.h> +#include <fcntl.h> +#include <sys/types.h> +#include <stdio.h> + +int main (int argc,char **argv) +{ +int fd; +int j; +int i; +int buf[1024 ]; + + fd =open (argv[1 ],O_RDWR |O_CREAT ,0666 ); +for (i =1 ; i <9100 ; i++) { +for (j =0 ; j <1024 ; j++) + buf[j] = i | i <<5 ; + +if (write (fd,buf,253 *4 *sizeof (int ))!=253 *4 *sizeof (int )) +printf ("Write did not return correct amount\n" ); + +if ((i %9 ) ==0 && i <9001 ) +lseek (fd,4096 *110 ,SEEK_CUR ); + } + +close (fd); + +return 0 ; +}
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
On Thu, Apr 29, 2010 at 06:34:44AM -0400, Christoph Hellwig wrote:
| This is an adapted version of the reproduced in OSS BZ #874, which | shows file corruption when using the extent size hint. | | Geoffrey, can you say if licensing the small test program as GPLv2+ | is fine so that we can add it to xfstests?
Thanks for asking Christoph. Please include an SGI copyright in both the test script and the t_holes.c source. The GPLv2+ license is fine.
/*
* Copyright (c) 2010 SGI.
* All rights reserved.
*/
Signature · 10 lines
Geoffrey Wehrman SGI Building 10 Office: (651)683-5496 2750 Blue Water Road Fax: (651)683-5098 Eagan, MN 55121 E-mail: [email protected] http://www.sgi.com/products/storage/ _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 9 lines · Geoffrey Wehrman
On Thu, Apr 29, 2010 at 06:34:44AM -0400, Christoph Hellwig wrote:
| This is an adapted version of the reproduced in OSS BZ #874, which | shows file corruption when using the extent size hint. | | Geoffrey, can you say if licensing the small test program as GPLv2+ | is fine so that we can add it to xfstests?Thanks for asking Christoph. Please include an SGI copyright in both the test script and the
t_holes.csource. The GPLv2+ license is fine.
Is this version fine to commit?
Geoffrey, if you could add a Signed-off-by: that would be perfect, thanks!
---
From: Christoph Hellwig <[email protected]>
Subject: [PATCH] xfstests: test extent size hints
Cc: Geoffrey Wehrman <[email protected]>
This is an adapted version of the reproduced in OSS BZ #874, which shows file corruption when using the extent size hint.
Geoffrey, can you say if licensing the small test program as GPLv2+ is fine so that we can add it to xfstests?
Signed-off-by Christoph Hellwig <[email protected]>
229 new file +88 -0
@@ -0,0 +1,88 @@ +#! /bin/bash +# FS QA Test No. 221 +# +# Check for file corruption when using the extent size hint on +# the normal data subvolume. +# +# http://oss.sgi.com/bugzilla/show_bug.cgi?id=874 +# +# Based on a bug report and testcase from Geoffrey Wehrman <[email protected]>. +# +#----------------------------------------------------------------------- +# Copyright (c) 2010 Christoph Hellwig. All Rights Reserved. +# Copyright (c) 2010 Silicon Graphics, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# +#----------------------------------------------------------------------- +# +# creator [email protected] + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + rm -rf ${TDIR} +} + +trap "_cleanup ; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common.rc + +# real QA test starts here +_supported_fs generic +_supported_os Linux + +TDIR="${TEST_DIR}/t_holes" +NFILES="10" +EXTSIZE="256k" + +# Create the test directory +mkdir ${TDIR} + +# Set the test directory extsize +xfs_io -c "extsize ${EXTSIZE}" ${TDIR} + +# Create a set of holey files +echo "generating ${NFILES} files" + +for i in $(seq 0 ${NFILES}); do + $here/src/t_holes ${TDIR}/${i} +done + +# Compare the files +echo "comparing files" +errcnt=0 +j=0 +for i in $(seq 0 ${NFILES}); do + let j=$i+1 + while [ ${j} -lt ${NFILES} ] ; do + if ! cmp ${TDIR}/${i} ${TDIR}/${j} ; then + let errcnt=$errcnt+1 + fi + let j=$j+1 + done +done + +echo "got ${errcnt} errors" + +status=$errcnt +exit $status
229.out new file +4 -0
@@ -0,0 +1,4 @@ +QA output created by 229 +generating 10 files +comparing files +got 0 errors
group +1 -0
@@ -342,3 +342,4 @@ deprecated 226 auto enospc 227 auto fsr 228 rw auto prealloc quick +229 auto rw
src/Makefile +1 -1
@@ -10,7 +10,7 @@ TARGETS = dirstress fill fill2 getpagesi mmapcat append_reader append_writer dirperf metaperf \ devzero feature alloc fault fstest t_access_root \ godown resvtest writemod makeextents itrash rename \ - multi_open_unlink dmiperf unwritten_sync genhashnames + multi_open_unlink dmiperf unwritten_sync genhashnames t_holes LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \ preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \
src/t_holes.c new file +41 -0
41 lines not on this page · raw message
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
On Mon, May 10, 2010 at 01:26:43PM -0400, Christoph Hellwig wrote:
| On Thu, Apr 29, 2010 at 10:10:03AM -0500, Geoffrey Wehrman wrote: | > On Thu, Apr 29, 2010 at 06:34:44AM -0400, Christoph Hellwig wrote: | > | This is an adapted version of the reproduced in OSS BZ #874, which | > | shows file corruption when using the extent size hint. | > | | > | Geoffrey, can you say if licensing the small test program as GPLv2+ | > | is fine so that we can add it to xfstests? | > | > Thanks for asking Christoph. Please include an SGI copyright in both | > the test script and the t_holes.c source. The GPLv2+ license is fine. | | Is this version fine to commit?
Looks great. Thanks!
| Geoffrey, if you could add a Signed-off-by: that would be perfect, | thanks!
Done.
Geoffrey
---
From: Christoph Hellwig <[email protected]>
Subject: [PATCH] xfstests: test extent size hints
Cc: Geoffrey Wehrman <[email protected]>
This is an adapted version of the reproduced in OSS BZ #874, which shows file corruption when using the extent size hint.
Geoffrey, can you say if licensing the small test program as GPLv2+ is fine so that we can add it to xfstests?
Signed-off-by Christoph Hellwig <[email protected]>
Signed-off-by Geoffrey Wehrman <[email protected]>
229 new file +88 -0
@@ -0,0 +1,88 @@ +#! /bin/bash +# FS QA Test No. 221 +# +# Check for file corruption when using the extent size hint on +# the normal data subvolume. +# +# http://oss.sgi.com/bugzilla/show_bug.cgi?id=874 +# +# Based on a bug report and testcase from Geoffrey Wehrman <[email protected]>. +# +#----------------------------------------------------------------------- +# Copyright (c) 2010 Christoph Hellwig. All Rights Reserved. +# Copyright (c) 2010 Silicon Graphics, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# +#----------------------------------------------------------------------- +# +# creator [email protected] + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + rm -rf ${TDIR} +} + +trap "_cleanup ; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common.rc + +# real QA test starts here +_supported_fs generic +_supported_os Linux + +TDIR="${TEST_DIR}/t_holes" +NFILES="10" +EXTSIZE="256k" + +# Create the test directory +mkdir ${TDIR} + +# Set the test directory extsize +xfs_io -c "extsize ${EXTSIZE}" ${TDIR} + +# Create a set of holey files +echo "generating ${NFILES} files" + +for i in $(seq 0 ${NFILES}); do + $here/src/t_holes ${TDIR}/${i} +done + +# Compare the files +echo "comparing files" +errcnt=0 +j=0 +for i in $(seq 0 ${NFILES}); do + let j=$i+1 + while [ ${j} -lt ${NFILES} ] ; do + if ! cmp ${TDIR}/${i} ${TDIR}/${j} ; then + let errcnt=$errcnt+1 + fi + let j=$j+1 + done +done + +echo "got ${errcnt} errors" + +status=$errcnt +exit $status
229.out new file +4 -0
@@ -0,0 +1,4 @@ +QA output created by 229 +generating 10 files +comparing files +got 0 errors
group +1 -0
@@ -342,3 +342,4 @@ deprecated 226 auto enospc 227 auto fsr 228 rw auto prealloc quick +229 auto rw
src/Makefile +1 -1
@@ -10,7 +10,7 @@ TARGETS = dirstress fill fill2 getpagesi mmapcat append_reader append_writer dirperf metaperf \ devzero feature alloc fault fstest t_access_root \ godown resvtest writemod makeextents itrash rename \ - multi_open_unlink dmiperf unwritten_sync genhashnames + multi_open_unlink dmiperf unwritten_sync genhashnames t_holes LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \ preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \
src/t_holes.c new file +41 -0
41 lines not on this page · raw message
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs