ring-buffer: Wrap open-coded WARN_ONCE
Subsystems (2)
PATCH 1/1 ring-buffer: Wrap open-coded WARN_ONCE
Wrap open-coded WARN_ONCE functionality into the equivalent macro.
Signed-off-by Borislav Petkov <[email protected]>
--- kernel/trace/ring_buffer.c | 14 +++++--------- 1 files changed, 5 insertions(+), 9 deletions(-)
kernel/trace/ring_buffer.c +5 -9
@@ -1979,17 +1979,13 @@ rb_add_time_stamp(struct ring_buffer_per_cpu *cpu_buffer, u64 *ts, u64 *delta) {struct ring_buffer_event *event; -static int once;int ret; -if (unlikely (*delta > (1ULL <<59 ) && !once++)) { -printk (KERN_WARNING "Delta way too big! %llu" -" ts=%llu write stamp = %llu\n" , - (unsigned long long )*delta, - (unsigned long long )*ts, - (unsigned long long )cpu_buffer->write_stamp); -WARN_ON (1 ); - } +WARN_ONCE (*delta > (1ULL <<59 ), +KERN_WARNING "Delta way too big! %llu ts=%llu write stamp = %llu\n" , + (unsigned long long )*delta, + (unsigned long long )*ts, + (unsigned long long )cpu_buffer->write_stamp);/* * The delta is too big, we to add a
Signature · 6 lines
1.7.0.3
--
Regards/Gruss,
Boris.Commit-ID: 956097912c40a03bf22603a3be73503fd9ea9e44 Gitweb: http://git.kernel.org/tip/956097912c40a03bf22603a3be73503fd9ea9e44 Author: Borislav Petkov <[email protected]> AuthorDate: Sun, 2 May 2010 08:03:54 +0200 Committer: Steven Rostedt <[email protected]> CommitDate: Tue, 4 May 2010 12:23:47 -0400
ring-buffer: Wrap open-coded WARN_ONCE
Wrap open-coded WARN_ONCE functionality into the equivalent macro.
Signed-off-by Borislav Petkov <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by Steven Rostedt <[email protected]>
--- kernel/trace/ring_buffer.c | 14 +++++--------- 1 files changed, 5 insertions(+), 9 deletions(-)
kernel/trace/ring_buffer.c +5 -9
@@ -2000,17 +2000,13 @@ rb_add_time_stamp(struct ring_buffer_per_cpu *cpu_buffer, u64 *ts, u64 *delta) {struct ring_buffer_event *event; -static int once;int ret; -if (unlikely (*delta > (1ULL <<59 ) && !once++)) { -printk (KERN_WARNING "Delta way too big! %llu" -" ts=%llu write stamp = %llu\n" , - (unsigned long long )*delta, - (unsigned long long )*ts, - (unsigned long long )cpu_buffer->write_stamp); -WARN_ON (1 ); - } +WARN_ONCE (*delta > (1ULL <<59 ), +KERN_WARNING "Delta way too big! %llu ts=%llu write stamp = %llu\n" , + (unsigned long long )*delta, + (unsigned long long )*ts, + (unsigned long long )cpu_buffer->write_stamp);/* * The delta is too big, we to add a