nilfs2: enlarge s_volume_name member in nilfs_super_block
PATCH v2 1/1 nilfs2: enlarge s_volume_name member in nilfs_super_block
Hi,
Here is the patch against linux-next tree.
Current s_volume_name has 16 bytes, which is too small as modern filesystem.
s_last_mounted resides just after s_volume_name and has 64 bytes.
s_last_mounted is historically came from ext2, but not used in nilfs2 at all. Deleting s_last_mounted member and merging that space with s_volume_name enlarge s_volume_name upto 80 bytes for volume label.
When user land tools see the old header for new disk, it will just ignore additional bytes stored in s_last_mounted. While, old disk format has only 16 bytes label, it doesn't affects in case seeing the new header for old disk.
--- include/linux/nilfs2_fs.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
include/linux/nilfs2_fs.h +1 -2
@@ -207,8 +207,7 @@ struct nilfs_super_block {__le16 s_segment_usage_size;/* Size of a segment usage */ __u8 s_uuid[16 ];/* 128-bit uuid for volume */ -char s_volume_name[16 ];/* volume name */ -char s_last_mounted[64 ];/* directory where last mounted */ +char s_volume_name[80 ];/* volume name */ __le32 s_c_interval;/* Commit interval of segment */ __le32 s_c_block_max;/* Threshold of data amount for
Signature · 6 lines
1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 877hnm4btb.wl%[email protected]
Ryusuke Konishi
AppliedHi,
Quoted 12 lines · Jiro SEKIBA
Hi,
Here is the patch against linux-next tree.
Current
s_volume_namehas 16 bytes, which is too small as modern filesystem.
s_last_mountedresides just afters_volume_nameand has 64 bytes.
s_last_mountedis historically came from ext2, but not used in nilfs2 at all. Deletings_last_mountedmember and merging that space withs_volume_nameenlarges_volume_nameupto 80 bytes for volume label.
Quoted 5 lines
When user land tools see the old header for new disk, it will just ignore additional bytes stored in
s_last_mounted. While, old disk format has only 16 bytes label, it doesn't affects in case seeing the new header for old disk.Signed-off-by Jiro SEKIBA <[email protected]>
Applied to the for-next branch.
Thank you!
Ryusuke Konishi
Quoted 25 lines
--- include/linux/nilfs2_fs.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)include/linux/nilfs2_fs.h +1
-2@@ -207,8 +207,7 @@ struct nilfs_super_block {__le16 s_segment_usage_size;/* Size of a segment usage */ __u8 s_uuid[16 ];/* 128-bit uuid for volume */ -char s_volume_name[16 ];/* volume name */ -char s_last_mounted[64 ];/* directory where last mounted */ +char s_volume_name[80 ];/* volume name */ __le32 s_c_interval;/* Commit interval of segment */ __le32 s_c_block_max;/* Threshold of data amount for Signature · 6 lines
1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html