net/usb: initiate sync sequence in sierra_net.c driver

PATCH In review Elina Pasheva 3 participants 6 messages Apr 28, 2010 – May 4, 2010 1 message not in the archive

Subsystems (3)

Networking Network drivers USB networking drivers

lore

Share & tools

lore

Elina Pasheva

author

2010-04-28 23:28 UTC #0 lore raw

PATCH 1/1 net/usb: initiate sync sequence in sierra_net.c driver

Subject: [PATCH 1/1] net/usb: initiate sync sequence in sierra_net.c driver
From: Elina Pasheva <[email protected]>

The following patch adds the initiation of the sync sequence to "sierra_net_bind()". If this step is omitted, the modem will never sync up with the host and it will not be possible to establish a data connection. This is a high priority patch.

This patch has been checked against net-2.6 tree.

Signed-off-by Elina Pasheva <[email protected]>

Signed-off-by Rory Filer <[email protected]>

Tested-by Elina Pasheva <[email protected]>

---
 drivers/net/usb/sierra_net.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

drivers/net/usb/sierra_net.c +3 -0

index a44f9e0..f1942d6 100644
@@ -789,6 +789,9 @@ static int sierra_net_bind(struct usbnet *dev, struct usb_interface *intf)
 	/* prepare sync message from template */
 	memcpy(priv->sync_msg, sync_tmplate, sizeof(priv->sync_msg));
 
+	/* initiate the sync sequence */
+	sierra_net_dosync(dev);
+
 	return 0;
 }

Signature · 8 lines

1.5.4.3



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

David Miller

2010-05-02 01:08 UTC #1 lore raw

From: Elina Pasheva <[email protected]>
Date: Wed, 28 Apr 2010 16:28:24 -0700

Quoted 8 lines

Subject: [PATCH 1/1] net/usb: initiate sync sequence in sierra_net.c driver
From: Elina Pasheva <[email protected]>
The following patch adds the initiation of the sync sequence to "sierra_net_bind()". If this step is omitted, the modem will never sync up with the host and it will not be possible to establish a data connection. This is a high priority patch.

Quoted 4 lines

This patch has been checked against net-2.6 tree.
Signed-off-by Elina Pasheva <[email protected]>
Signed-off-by Rory Filer <[email protected]>
Tested-by Elina Pasheva <[email protected]>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Elina Pasheva

2010-05-02 05:57 UTC #2 lore raw

Quoted 14 lines · David Miller

Quoted 12 lines
From: Elina Pasheva <[email protected]>
Date: Wed, 28 Apr 2010 16:28:24 -0700
Subject: [PATCH 1/1] net/usb: initiate sync sequence in sierra_net.c driver
From: Elina Pasheva <[email protected]>
The following patch adds the initiation of the sync sequence to "sierra_net_bind()". If this step is omitted, the modem will never sync up with the host and it will not be possible to establish a data connection. This is a high priority patch.

Quoted 6 lines

Quoted 4 lines
This patch has been checked against net-2.6 tree.
Signed-off-by Elina Pasheva <[email protected]>
Signed-off-by Rory Filer <[email protected]>
Tested-by Elina Pasheva <[email protected]>
Applied.

Thank you very much, David!
Elina

Elina Pasheva

2010-05-04 20:18 UTC #3 lore raw

In reply to David Miller

Quoted 18 lines

Quoted 17 lines · David Miller
Quoted 16 lines
From: Elina Pasheva <[email protected]>
Date: Wed, 28 Apr 2010 16:28:24 -0700
Subject: [PATCH 1/1] net/usb: initiate sync sequence in sierra_net.c driver
From: Elina Pasheva <[email protected]>
The following patch adds the initiation of the sync sequence to "sierra_net_bind()". If this step is omitted, the modem will never sync up with the host and it will not be possible to establish a data connection. This is a high priority patch.
This patch has been checked against net-2.6 tree.
Signed-off-by Elina Pasheva <[email protected]>
Signed-off-by Rory Filer <[email protected]>
Tested-by Elina Pasheva <[email protected]>

Quoted 4 lines

Quoted 1 line
Applied.
Thank you very much, David!
Elina

Hi David,
What are the chances of this patch to be in the kernel-2.6.34 release? Without this patch the driver sierra_net (currently in kernel-2.6.34-rc6) will not work.

Thank you,
Elina

David Miller

2010-05-04 21:53 UTC #4 lore raw

From: Elina Pasheva <[email protected]>
Date: Tue, 4 May 2010 13:18:22 -0700

Quoted 3 lines

What are the chances of this patch to be in the kernel-2.6.34 release? Without this patch the driver sierra_net (currently in kernel-2.6.34-rc6) will not work.

It's sitting in my net-2.6 tree which means it will go to Linus the next time I send him a pull request. I have no idea when that will be, but hopefully it will be soon.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20100504.145357.111558943.davem-fT/PcQaiUtIeIZ0/[email protected]

Elina Pasheva

author

2010-05-04 22:15 UTC #6 lore raw

Quoted 11 lines · David Miller

From: Elina Pasheva <[email protected]>
Date: Tue, 4 May 2010 13:18:22 -0700
Quoted 3 lines
What are the chances of this patch to be in the kernel-2.6.34 release? Without this patch the driver sierra_net (currently in kernel-2.6.34-rc6) will not work.
It's sitting in my net-2.6 tree which means it will go to Linus the next time I send him a pull request. I have no idea when that will be, but hopefully it will be soon.

Sounds good. Thank you, David.
Elina

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html