media/mem2mem: dereferencing free memory

PATCH New Dan Carpenter 1 participant 1 message May 5, 2010 Media (V4L/DVB)

lore

Share & tools

lore

Dan Carpenter

author

2010-05-05 05:59 UTC #0 lore raw

PATCH 1/1 media/mem2mem: dereferencing free memory

We dereferenced "ctx" on the error path.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/video/mem2mem_testdev.c +3 -1

index baf211b..b161d26 100644
@@ -871,8 +871,10 @@ static int m2mtest_open(struct file *file)
 
 	ctx->m2m_ctx = v4l2_m2m_ctx_init(ctx, dev->m2m_dev, queue_init);
 	if (IS_ERR(ctx->m2m_ctx)) {
+		int ret = PTR_ERR(ctx->m2m_ctx);
+
 		kfree(ctx);
-		return PTR_ERR(ctx->m2m_ctx);
+		return ret;
 	}
 
 	atomic_inc(&dev->num_inst);