Skip to contentSkip to conversation

ipmi: Update driver to use dev_printk and its constructs

PATCH New Corey Minyard 1 participant 1 message May 6, 2010 IPMI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipmi: Update driver to use dev_printk and its constructs

From: Myron Stowe <[email protected]>

Update core IPMI driver printk()'s with dev_printk(), and its constructs, to provide additional device topology information.

An example of the additional device topology for a PNP device -
ipmi_si 00:02: probing via ACPI
ipmi_si 00:02: [io 0x0ca2-0x0ca3] regsize 1 spacing 1 irq 0 ipmi_si 00:02: Found new BMC (man_id: 0x00000b, prod_id: 0x0000, ... ipmi_si 00:02: IPMI kcs interface initialized

and for a PCI device -
ipmi_si 0000:01:04.6: probing via PCI
ipmi_si 0000:01:04.6: PCI INT A -> GSI 21 (level, low) -> IRQ 21 ipmi_si 0000:01:04.6: [mem 0xf1ef0000-0xf1ef00ff] regsize 1 spaci... ipmi_si 0000:01:04.6: IPMI kcs interface initialized

--

Reworked this because some patches from Matthew Garrett broke it, and I fixed a few other items of the same nature. -Corey

drivers/char/ipmi/ipmi_msghandler.c +5 -6
Index: linux-2.6/drivers/char/ipmi/ipmi_msghandler.c
===================================================================
@@ -2505,12 +2505,11 @@ static int ipmi_bmc_register(ipmi_smi_t 
 			return rv;
 		}
 
-		printk(KERN_INFO
-		       "ipmi: Found new BMC (man_id: 0x%6.6x, "
-		       " prod_id: 0x%4.4x, dev_id: 0x%2.2x)\n",
-		       bmc->id.manufacturer_id,
-		       bmc->id.product_id,
-		       bmc->id.device_id);
+		dev_info(intf->si_dev, "Found new BMC (man_id: 0x%6.6x, "
+			 "prod_id: 0x%4.4x, dev_id: 0x%2.2x)\n",
+			 bmc->id.manufacturer_id,
+			 bmc->id.product_id,
+			 bmc->id.device_id);
 	}
 
 	/*
drivers/char/ipmi/ipmi_si_intf.c +102 -121

562 lines not on this page · raw message