pxa3xx_nand: refuse the flash definition get from platform
PATCH 1/20 pxa3xx_nand: refuse the flash definition get from platform
PATCH 1/20 pxa3xx_nand: refuse the flash definition get from platform
Hi,
I'd like to test this, but ...
Quoted 20 lines · Haojian Zhuang
From
135f6369a9c045e58d2cfa445c72bae2bbc645cdMon Sep 17 00:00:00 2001
From: Lei Wen <[email protected]>
Date: Sat, 20 Mar 2010 19:01:23 +0800
Subject: [PATCH]pxa3xx_nand: refuse the flash definition get from platformFor current usage, it is little reason to use a platform defined flash info for the flash detection. Flash timing through platform should be the same. And allow multiple platform to define the same flash chip would be a waste.
Also condense the flash definition way in the c file to simplify adding a new chip.
Signed-off-by Lei Wen <[email protected]>Signed-off-by Haojian Zhuang <[email protected]>--- arch/arm/plat-pxa/include/plat/pxa3xx_nand.h | 40 ---- drivers/mtd/nand/Kconfig | 7 - drivers/mtd/nand/pxa3xx_nand.c | 251 ++++++-------------------- 3 files changed, 60 insertions(+), 238 deletions(-)
[...]
Quoted 10 lines
(quoted diff) +6
-0+static struct pxa3xx_nand_flash __devinitdata builtin_flash_types[] = { +{ 0x46ec, 32, 512, 16, 16, 4096, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, }, +{ 0xdaec, 64, 2048, 8, 8, 2048, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, }, +{ 0xd7ec, 128, 4096, 8, 8, 8192, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, }, +{ 0xa12c, 64, 2048, 8, 8, 1024, { 10, 25, 15, 25, 15, 30, 25000, 60, 10, }, }, +{ 0xb12c, 64, 2048, 16, 16, 1024, { 10, 25, 15, 25, 15, 30, 25000,60, 10, }, },
(quoted diff) +2
-0+{ 0xdc2c, 64, 2048, 8, 8, 4096, { 10, 25, 15, 25, 15, 30, 25000, 60, 10, }, }, +{ 0xcc2c, 64, 2048, 16, 16, 4096, { 10, 25, 15, 25, 15, 30, 25000,60, 10, }, },
That series is line-wrapped. Could you fix this and resend please?
Daniel
PATCH 1/20 pxa3xx_nand: refuse the flash definition get from platform
Quoted 41 lines · Daniel Mack
Hi,
I'd like to test this, but ...
Quoted 20 lines · Haojian Zhuang
From
135f6369a9c045e58d2cfa445c72bae2bbc645cdMon Sep 17 00:00:00 2001
From: Lei Wen <[email protected]>
Date: Sat, 20 Mar 2010 19:01:23 +0800
Subject: [PATCH]pxa3xx_nand: refuse the flash definition get from platformFor current usage, it is little reason to use a platform defined flash info for the flash detection. Flash timing through platform should be the same. And allow multiple platform to define the same flash chip would be a waste.
Also condense the flash definition way in the c file to simplify adding a new chip.
Signed-off-by Lei Wen <[email protected]>Signed-off-by Haojian Zhuang <[email protected]>---
?arch/arm/plat-pxa/include/plat/pxa3xx_nand.h | ? 40 ---- ?drivers/mtd/nand/Kconfig ? ? ? ? ? ? ? ? ? ? | ? ?7 - ?drivers/mtd/nand/pxa3xx_nand.c ? ? ? ? ? ? ? | ?251 ++++++--------------------?3 files changed, 60 insertions(+), 238 deletions(-)
[...]
Quoted 10 lines
(quoted diff) +6
-0+static struct pxa3xx_nand_flash __devinitdata builtin_flash_types[] = { +{ 0x46ec, 32, 512, 16, 16, 4096, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, }, +{ 0xdaec, 64, 2048, 8, 8, 2048, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, }, +{ 0xd7ec, 128, 4096, 8, 8, 8192, { 10, 0, 20, 40, 30, 40, 11123, 110, 10, }, }, +{ 0xa12c, 64, 2048, 8, 8, 1024, { 10, 25, 15, 25, 15, 30, 25000, 60, 10, }, }, +{ 0xb12c, 64, 2048, 16, 16, 1024, { 10, 25, 15, 25, 15, 30, 25000,60, 10, }, },
(quoted diff) +2
-0+{ 0xdc2c, 64, 2048, 8, 8, 4096, { 10, 25, 15, 25, 15, 30, 25000, 60, 10, }, }, +{ 0xcc2c, 64, 2048, 16, 16, 4096, { 10, 25, 15, 25, 15, 30, 25000,60, 10, }, },
That series is line-wrapped. Could you fix this and resend please?
Quoted 3 lines
Daniel
Now I attached these patches. Try these.
Thanks
Haojian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pxa3xx_nand.tgz
Type: application/x-gzip
Size: 43457 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100507/fdd69adf/attachment-0001.tgz>