Skip to contentSkip to conversation

Oprofile: Change CPUIDS from decimal to hex, and add some comments

PATCH In review John Villalovos 2 participants 2 messages May 7, 2010 – May 10, 2010 x86

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Oprofile: Change CPUIDS from decimal to hex, and add some comments

Version 2:

Incorporating suggested changes from Robert Richter.

Back when the patch was submitted for "Add Xeon 7500 series support to oprofile", Robert Richter had asked for a followon patch that converted all the CPU ID values to hex.

I have done that here for the "i386/core_i7" and "i386/atom" class processors in the ppro_init() function and also added some comments on where to find documentation on the Intel processors.

arch/x86/oprofile/nmi_int.c +9 -2
index 9f001d9..2de5f44 100644
@@ -586,6 +586,13 @@ static int __init ppro_init(char **cpu_type)
 	if (force_arch_perfmon && cpu_has_arch_perfmon)
 		return 0;
 
+	/* Documentation on identifying Intel processors by CPU Family and Model
+	 * can be found in the Intel Software Developer's Manual (SDM).
+	 * http://www.intel.com/products/processor/manuals/
+	 * As of May 2010 the documentation for this was in the:
+	 * "Intel 64 and IA-32 Architectures Software Developer's Manual Volume
+	 * 3B: System Programming Guide",
+	 * "Table B-1 CPUID Signature Values of DisplayFamily_DisplayModel" */
 	switch (cpu_model) {
 	case 0 ... 2:
 		*cpu_type = "i386/ppro";
@@ -607,12 +614,12 @@ static int __init ppro_init(char **cpu_type)
 	case 15: case 23:
 		*cpu_type = "i386/core_2";
 		break;
+	case 0x1a:
 	case 0x2e:
-	case 26:
 		spec = &op_arch_perfmon_spec;
 		*cpu_type = "i386/core_i7";
 		break;
-	case 28:
+	case 0x1c:
 		*cpu_type = "i386/atom";
 		break;
 	default:
Signature · 2 lines
John Villalovos
Intel Corporation on-site partner engineer at Red Hat, Inc.
#1 lore raw
Quoted 22 lines · John Villalovos

Version 2:

Incorporating suggested changes from Robert Richter.

Back when the patch was submitted for "Add Xeon 7500 series support to oprofile", Robert Richter had asked for a followon patch that converted all the CPU ID values to hex.

I have done that here for the "i386/core_i7" and "i386/atom" class processors in the ppro_init() function and also added some comments on where to find documentation on the Intel processors.

arch/x86/oprofile/nmi_int.c +0 -0
index 9f001d9..2de5f44 100644
@@ -586,6 +586,13 @@ static int __init ppro_init(char **cpu_type)
 	if (force_arch_perfmon && cpu_has_arch_perfmon)
 		return 0;
 

arch/x86/oprofile/nmi_int.c static int __init ppro_init(char **cpu_type) · line 598

Quoted 10 lines
arch/x86/oprofile/nmi_int.c +7 -0
+	/* Documentation on identifying Intel processors by CPU Family and Model
+	 * can be found in the Intel Software Developer's Manual (SDM).
+	 * http://www.intel.com/products/processor/manuals/
+	 * As of May 2010 the documentation for this was in the:
+	 * "Intel 64 and IA-32 Architectures Software Developer's Manual Volume
+	 * 3B: System Programming Guide",
+	 * "Table B-1 CPUID Signature Values of DisplayFamily_DisplayModel" */
 	switch (cpu_model) {
 	case 0 ... 2:
 		*cpu_type = "i386/ppro";

Patch applied, thanks John. I made some small style changes to your comment:

/*
* Documentation on identifying Intel processors by CPU family
* and model can be found in the Intel Software Developer's
* Manuals (SDM):
*
* http://www.intel.com/products/processor/manuals/
*
* As of May 2010 the documentation for this was in the:
* "Intel 64 and IA-32 Architectures Software Developer's
* Manual Volume 3B: System Programming Guide", "Table B-1
* CPUID Signature Values of DisplayFamily_DisplayModel". */

-Robert

Signature · 3 lines
Advanced Micro Devices, Inc.
Operating System Research Center
email: [email protected]