Skip to contentSkip to conversation

remove useless free(ptr) calls on NULL ptr

PATCH New Serge Ziryukin 3 participants 3 messages May 10, 2010 – May 17, 2010 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove useless free(ptr) calls on NULL ptr

---
 drivers/net/lan91c96.c |    1 -
 drivers/net/smc911x.c  |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)
drivers/net/lan91c96.c +0 -1
index 90e4002..810079f 100644
@@ -795,7 +795,6 @@ int lan91c96_initialize(u8 dev_num, int base_addr)
 
 	dev = malloc(sizeof(*dev));
 	if (!dev) {
-		free(dev);
 		return 0;
 	}
 	memset(dev, 0, sizeof(*dev));
drivers/net/smc911x.c +0 -1
index f2fc88b..3da4c35 100644
@@ -242,7 +242,6 @@ int smc911x_initialize(u8 dev_num, int base_addr)
 
 	dev = malloc(sizeof(*dev));
 	if (!dev) {
-		free(dev);
 		return -1;
 	}
 	memset(dev, 0, sizeof(*dev));
Signature · 1 line
1.7.1
#2 lore raw

PATCH 1/1 remove useless free(ptr) calls on NULL ptr

In reply to Serge Ziryukin

Dear Serge Ziryukin,

Quoted 5 lines · In message <[email protected]> you wrote:
---
 drivers/net/lan91c96.c |    1 -
 drivers/net/smc911x.c  |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If that makes any sense to you, you have a big problem."
                                  -- C. Durance, Computer Science 234