Skip to contentSkip to conversation

PCI: return correct value when writing to the "reset" attribute

PATCH Michael S. Tsirkin 1 participant 1 message May 11, 2010 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Michael S. Tsirkin

author Acked-by
#1 lore raw
Quoted 5 lines · Michal Schmidt

A successful write() to the "reset" sysfs attribute should return the number of bytes written, not 0. Otherwise userspace (bash) retries the write over and over again.

Quoted 23 lines

---

 drivers/pci/pci-sysfs.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
drivers/pci/pci-sysfs.c +6 -1
index fad9398..ba88a2f 100644
@@ -960,7 +960,12 @@ static ssize_t reset_store(struct device *dev,
 
 	if (val != 1)
 		return -EINVAL;
-	return pci_reset_function(pdev);
+
+	result = pci_reset_function(pdev);
+	if (result < 0)
+		return result;
+
+	return count;
 }
 
 static struct device_attribute reset_attr = __ATTR(reset, 0200, NULL, reset_store);