crashdump: do not fail on null pointer dereferencing
PATCH 1/1 crashdump: do not fail on null pointer dereferencing
Best regards,
Maxim Uvarov.
From: Maxim Uvarov <[email protected]>
Signed-off-by Maxim Uvarov <[email protected]>
---
arch/powerpc/kernel/crash.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
arch/powerpc/kernel/crash.c +3 -0
@@ -375,6 +375,9 @@ void default_machine_crash_shutdown(struct pt_regs *regs)for_each_irq (i) {struct irq_desc *desc =irq_to_desc (i); +if (!desc || !desc->chip || !desc->chip->eoi) +continue ; +if (desc->status &IRQ_INPROGRESS ) desc->chip->eoi (i);
Hi,
arch/powerpc/kernel/crash.c void default_machine_crash_shutdown(struct pt_regs *r=
Quoted 5 lines
arch/powerpc/kernel/crash.c +0
-0@@ -375,6 +375,9 @@ void default_machine_crash_shutdown(struct pt_regs *r=
egs)
arch/powerpc/kernel/crash.c void default_machine_crash_shutdown(struct pt_regs *r= · line 378
Quoted 4 lines
arch/powerpc/kernel/crash.c +1
-0=A0 =A0 =A0 =A0for_each_irq(i) { =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0struct irq_desc *desc =3D irq_to_desc(i); + =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (!desc || !desc->chip || !desc->chip->eo=
i)
arch/powerpc/kernel/crash.c void default_machine_crash_shutdown(struct pt_regs *r= · line 380
Quoted 2 lines
arch/powerpc/kernel/crash.c +2
-0+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 continue; +
Kinda unlikely that desc can be NULL here :)
~Vitaly
Quoted 10 lines · Vitaly Wool
Hi,
Quoted 8 lines
arch/powerpc/kernel/crash.c +0
-0@@ -375,6 +375,9 @@ void default_machine_crash_shutdown(struct pt_regs *regs)for_each_irq (i) {struct irq_desc *desc =irq_to_desc (i);
Quoted 3 lines
arch/powerpc/kernel/crash.c void default_machine_crash_shutdown(struct pt_regs *regs) · line 380
Quoted 3 lines
arch/powerpc/kernel/crash.c +3
-0+if (!desc || !desc->chip || !desc->chip->eoi) +continue ; +
Actually almost certain that desc will be NULL. When CONFIG_SPARSE_IRQ=y (the default), irq_desc's are allocated lazily.
cheers