Skip to contentSkip to conversation

h1940: framebuffer configuration fix

PATCH New Mike Solovyev 3 participants 5 messages May 12, 2010 – May 13, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 h1940: framebuffer configuration fix

Seems like a typo, wrong setup leads to broken image on ipaq screen.

---
 arch/arm/mach-s3c2410/mach-h1940.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-s3c2410/mach-h1940.c +2 -2
Index: linux-2.6/arch/arm/mach-s3c2410/mach-h1940.c
===================================================================
@@ -162,8 +162,8 @@ static struct s3c2410fb_display h1940_lc
 	.xres =		240,
 	.yres =		320,
 	.bpp =		16,
-	.left_margin =	20,
-	.right_margin =	8,
+	.left_margin =	8,
+	.right_margin =	20,
 	.hsync_len =	4,
 	.upper_margin =	8,
 	.lower_margin = 7,
#1 lore raw

PATCH 1/1 h1940: framebuffer configuration fix

Quoted 1 line · Mike Solovyev

Seems like a typo, wrong setup leads to broken image on ipaq screen.

arnaud, any comments here?

Quoted 26 lines
---
 arch/arm/mach-s3c2410/mach-h1940.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6/arch/arm/mach-s3c2410/mach-h1940.c
===================================================================

arch/arm/mach-s3c2410/mach-h1940.c +2 -2
@@ -162,8 +162,8 @@ static struct s3c2410fb_display h1940_lc
 	.xres =		240,
 	.yres =		320,
 	.bpp =		16,
-	.left_margin =	20,
-	.right_margin =	8,
+	.left_margin =	8,
+	.right_margin =	20,
 	.hsync_len =	4,
 	.upper_margin =	8,
 	.lower_margin = 7,

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 5 lines
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.
#2 lore raw

PATCH 1/1 h1940: framebuffer configuration fix

Quoted 4 lines · Ben Dooks
Quoted 1 line · Mike Solovyev

Seems like a typo, wrong setup leads to broken image on ipaq screen.

arnaud, any comments here?

I don't know where the typo came from (and I don't want to know) but this patch is really needed. I've been using Mike's patch for quite some time and I'll be happy to see it merged.

Thanks,
Arnaud

#3 lore raw

PATCH 1/1 h1940: framebuffer configuration fix

In reply to Mike Solovyev
Quoted 4 lines · Mike Solovyev

Seems like a typo, wrong setup leads to broken image on ipaq screen.

surely this should be an acked-by or similar?

Quoted 24 lines
---
 arch/arm/mach-s3c2410/mach-h1940.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6/arch/arm/mach-s3c2410/mach-h1940.c
===================================================================

arch/arm/mach-s3c2410/mach-h1940.c +2 -2
@@ -162,8 +162,8 @@ static struct s3c2410fb_display h1940_lc
 	.xres =		240,
 	.yres =		320,
 	.bpp =		16,
-	.left_margin =	20,
-	.right_margin =	8,
+	.left_margin =	8,
+	.right_margin =	20,
 	.hsync_len =	4,
 	.upper_margin =	8,
 	.lower_margin = 7,

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 5 lines
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.
#4 lore raw

PATCH 1/1 h1940: framebuffer configuration fix

Quoted 7 lines · On Thu, 13 May 2010 08:25:33 +0100 Ben Dooks <[email protected]> wrote:
Quoted 4 lines · Mike Solovyev

Seems like a typo, wrong setup leads to broken image on ipaq screen.

surely this should be an acked-by or similar?

I think the right way is:

will resend shortly

Signature · 8 lines
 ms -- http://sk.2-ch.org/gpg.pub
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100513/115928bc/attachment.sig>