serial: SAMSUNG: Fix dev_name and driver_name
PATCH 1/1 serial: SAMSUNG: Fix dev_name and driver_name
Thd dev_name and driver_name should be switched each other.
--- drivers/serial/samsung.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/serial/samsung.c +2 -2
@@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = {static struct uart_driver s3c24xx_uart_drv = { .owner =THIS_MODULE , - .dev_name ="s3c2410_serial" , + .dev_name =S3C24XX_SERIAL_NAME , .nr =CONFIG_SERIAL_SAMSUNG_UARTS , .cons =S3C24XX_SERIAL_CONSOLE , - .driver_name =S3C24XX_SERIAL_NAME , + .driver_name ="s3c2410_serial" , .major =S3C24XX_SERIAL_MAJOR , .minor =S3C24XX_SERIAL_MINOR , };
Signature · 1 line
1.7.0.4
PATCH 1/1 serial: SAMSUNG: Fix dev_name and driver_name
Quoted 1 line · Joonyoung Shim
Thd
dev_nameanddriver_nameshould be switched each other.
Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.
Please provide some information about what problem that this is fixing and the impact on any existing systems.
Quoted 24 lines
Signed-off-by Joonyoung Shim <[email protected]>--- drivers/serial/samsung.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/serial/samsung.c +2
-2@@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = {static struct uart_driver s3c24xx_uart_drv = { .owner =THIS_MODULE , - .dev_name ="s3c2410_serial" , + .dev_name =S3C24XX_SERIAL_NAME , .nr =CONFIG_SERIAL_SAMSUNG_UARTS , .cons =S3C24XX_SERIAL_CONSOLE , - .driver_name =S3C24XX_SERIAL_NAME , + .driver_name ="s3c2410_serial" , .major =S3C24XX_SERIAL_MAJOR , .minor =S3C24XX_SERIAL_MINOR , };Signature · 1 line
1.7.0.4
Signature · 5 lines
-- Ben Q: What's a light-year? A: One-third less calories than a regular year.
PATCH 1/1 serial: SAMSUNG: Fix dev_name and driver_name
Quoted 8 lines · Ben Dooks
Quoted 1 line · Joonyoung Shim
Thd
dev_nameanddriver_nameshould be switched each other.Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.
Please provide some information about what problem that this is fixing and the impact on any existing systems.
The serial device nodes are created to s3c2410_serial* on android platform instead of ttySAC*.
PATCH 1/1 serial: SAMSUNG: Fix dev_name and driver_name
Quoted 4 lines · Joonyoung Shim
Quoted 3 lines · Ben Dooks
Quoted 1 line · Joonyoung Shim
Thd
dev_nameanddriver_nameshould be switched each other.
Quoted 8 lines
Quoted 5 lines
Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.
Please provide some information about what problem that this is fixing and the impact on any existing systems.
The serial device nodes are created to s3c2410_serial* on android platform instead of ttySAC*.
This has been how they've been for ages, surely the android device node creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx, like many other operating sysyerms that can already do this.
Changing this just because android (something as-yet unmerged into mainline) does not like it. I'm not even happy with an #ifdef around this.
If you really feel this is a problem that you absolutely must fix in kernel then please provide a kernel commandline option to change the serial driver name and use that on any platform that needs it. Another way would be to update the serial platform data to have a field for which name to choose.
Signature · 4 lines
Ben Q: What's a light-year? A: One-third less calories than a regular year.
PATCH 1/1 serial: SAMSUNG: Fix dev_name and driver_name
Quoted 12 lines · Ben Dooks
Quoted 10 lines · Joonyoung Shim
Quoted 7 lines · Ben Dooks
Quoted 1 line · Joonyoung Shim
Thd
dev_nameanddriver_nameshould be switched each other.Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.
Please provide some information about what problem that this is fixing and the impact on any existing systems.
The serial device nodes are created to s3c2410_serial* on android platform instead of ttySAC*.
Quoted 7 lines
This has been how they've been for ages, surely the android device node creation sytstem supports symlinking
/dev/SACx->/dev/s3c2410_serialx, like many other operating sysyerms that can already do this.Changing this just because android (something as-yet unmerged into mainline) does not like it. I'm not even happy with an #ifdef around this.
I don't want this too. I wonder if "s3c2410_serial" dev_name is correct? Most serial drivers have tty prefix to dev_name, so i think ttySACx is more proper. Please see other serial drivers.