KVM: powerpc: fix init/exit annotation
Subsystems (3)
PATCH 1/1 KVM: powerpc: fix init/exit annotation
kvmppc_e500_exit() is a module_exit function, so it should be tagged with __exit, not __init. The incorrect annotation was added by commit 2986b8c72c272ea58edd37903b042c6da985627d.
--- arch/powerpc/kvm/e500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kvm/e500.c +1 -1
@@ -164,7 +164,7 @@ static int __init kvmppc_e500_init(void)return kvm_init (NULL ,sizeof (struct kvmppc_vcpu_e500 ),THIS_MODULE ); } -static void __init kvmppc_e500_exit (void ) +static void __exit kvmppc_e500_exit(void) {kvmppc_booke_exit (); }
Signature · 1 line
Jean Delvare
Hi, All,
Is there a status summary somewhere about Linux KVM on powerpc?
I am interested in KVM on MPC8572 with e500 core, and how about e500mc?
Is there bench mark testing results?
Thanks
Mu
________________________________________
From: [email protected] [[email protected]] On Behalf Of Jean Delvare [[email protected]]
Sent: Tuesday, May 18, 2010 12:34 AM
To: [email protected]
Cc: Stephen Rothwell; Avi Kivity
Subject: [PATCH] KVM: powerpc: fix init/exit annotation
kvmppc_e500_exit() is a module_exit function, so it should be tagged with __exit, not __init. The incorrect annotation was added by commit 2986b8c72c272ea58edd37903b042c6da985627d.
--- arch/powerpc/kvm/e500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kvm/e500.c 2010-05-18 09:21:08.000000000 +0200 renamed from arch/powerpc/kvm/e500.c 2010-05-17 18:51:04.000000000 +0200 +1 -1
@@ -164,7 +164,7 @@ static int __init kvmppc_e500_init(void) return kvm_init(NULL, sizeof(struct kvmppc_vcpu_e500), THIS_MODULE); } -static void __init kvmppc_e500_exit(void) +static void __exit kvmppc_e500_exit(void) { kvmppc_booke_exit(); }
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mu,
Please don't top-post.
Quoted 7 lines · Mu Lin
Hi, All,
Is there a status summary somewhere about Linux KVM on powerpc?
I am interested in KVM on MPC8572 with e500 core, and how about e500mc?
Is there bench mark testing results?
Please don't hi-jack discussion threads. Your question is unrelated with my patch, please start a new discussion thread.
Signature · 1 line
Jean Delvare
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 8 lines · Jean Delvare
kvmppc_e500_exit()is amodule_exitfunction, so it should be tagged with__exit, not__init. The incorrect annotation was added by commit2986b8c72c272ea58edd37903b042c6da985627d.Signed-off-by Jean Delvare <[email protected]>Cc Stephen Rothwell <[email protected]>Cc Avi Kivity <[email protected]>
Good catch!
Alex
Avi Kivity
AppliedQuoted 4 lines · Jean Delvare
kvmppc_e500_exit()is amodule_exitfunction, so it should be tagged with__exit, not__init. The incorrect annotation was added by commit2986b8c72c272ea58edd37903b042c6da985627d.
Applied, thanks.
Signature · 1 line
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
Hi Avi,
Quoted 6 lines · Avi Kivity
Quoted 3 lines · Jean Delvare
kvmppc_e500_exit()is amodule_exitfunction, so it should be tagged with__exit, not__init. The incorrect annotation was added by commit2986b8c72c272ea58edd37903b042c6da985627d.Applied, thanks.
Still not upstream?
Signature · 1 line
Jean Delvare
Quoted 6 lines · Jean Delvare
Hi Avi,
Quoted 2 lines · Avi Kivity
On 05/18/2010 10:34 AM, Jean Delvare wrote:
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
kvmppc_e500_exit()is amodule_exitfunction, so it should be tagged with__exit, not__init. The incorrect annotation was added by commit2986b8c72c272ea58edd37903b042c6da985627d.Applied, thanks.
Still not upstream?
It's queued, will get there within a few days.
Signature · 1 line
error compiling committee.c: too many arguments to function