Skip to contentSkip to conversation

block: remove all rcu head initializations

PATCH In review Paul E. McKenney 2 participants 5 messages May 18, 2010 – May 19, 2010 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block: remove all rcu head initializations

Hello, Jens,

Would you like to carry this patch, or should I push it up -tip? If I don't hear otherwise from you, I will push it up -tip. The INIT_RCU_HEAD() primitive is going away in favor of debugobjects.

Thanx, Paul

------------------------------------------------------------------------

block: remove all rcu head initializations

Remove all rcu head inits. We don't care about the RCU head state before passing it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can keep track of objects on stack.

block/cfq-iosched.c +0 -1
index 5f127cf..702d006 100644
@@ -3743,7 +3743,6 @@ static void *cfq_init_queue(struct request_queue *q)
 	 * second, in order to have larger depth for async operations.
 	 */
 	cfqd->last_delayed_sync = jiffies - HZ;
-	INIT_RCU_HEAD(&cfqd->rcu);
 	return cfqd;
 }
 
block/genhd.c +0 -1
index d13ba76..27e85a2 100644
@@ -987,7 +987,6 @@ int disk_expand_part_tbl(struct gendisk *disk, int partno)
 	if (!new_ptbl)
 		return -ENOMEM;
 
-	INIT_RCU_HEAD(&new_ptbl->rcu_head);
 	new_ptbl->len = target;
 
 	for (i = 0; i < len; i++)
#1 lore raw
Quoted 5 lines · Paul E. McKenney

Hello, Jens,

Would you like to carry this patch, or should I push it up -tip? If I don't hear otherwise from you, I will push it up -tip. The INIT_RCU_HEAD() primitive is going away in favor of debugobjects.

I'll queue it up, thanks!

Signature · 1 line
Jens Axboe
#2 lore raw
Quoted 8 lines · Jens Axboe
Quoted 5 lines · Paul E. McKenney

Hello, Jens,

Would you like to carry this patch, or should I push it up -tip? If I don't hear otherwise from you, I will push it up -tip. The INIT_RCU_HEAD() primitive is going away in favor of debugobjects.

I'll queue it up, thanks!

Let me know when you have it, and I will happily remove it from my tree. ;-)

Thanx, Paul

#3 lore raw
Quoted 4 lines · Paul E. McKenney
Quoted 3 lines · Jens Axboe
Quoted 2 lines · Paul E. McKenney

Hello, Jens,

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Would you like to carry this patch, or should I push it up -tip? If I don't hear otherwise from you, I will push it up -tip. The INIT_RCU_HEAD() primitive is going away in favor of debugobjects.

I'll queue it up, thanks!

Let me know when you have it, and I will happily remove it from my tree. ;-)

It was in when I sent the email, it's queued up in for-2.6.35 :-)

Signature · 1 line
Jens Axboe
#4 lore raw
Quoted 9 lines · Jens Axboe
Quoted 8 lines · Paul E. McKenney
Quoted 7 lines · Jens Axboe
Quoted 5 lines · Paul E. McKenney

Hello, Jens,

Would you like to carry this patch, or should I push it up -tip? If I don't hear otherwise from you, I will push it up -tip. The INIT_RCU_HEAD() primitive is going away in favor of debugobjects.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

I'll queue it up, thanks!

Let me know when you have it, and I will happily remove it from my tree. ;-)

It was in when I sent the email, it's queued up in for-2.6.35 :-)

;-)

Very good, I have removed it from my tree.

Thanx, Paul