Skip to contentSkip to conversation

miiphy.h vs linux/mii.h

U-Boot Mike Frysinger 2 participants 2 messages May 20, 2010

lore
Share & tools
lore
#0 lore raw

in reviewing some phy code i noticed that there's quite a good bit of duplication between miiphy.h and linux/mii.h. i imagine this is largely historical as miiphy.h dates back quite a long time, but moving forward, should we just do a mass conversion from the u-boot specific miiphy.h defines to the more common linux/mii.h defines ? should be easy to do for most with a few sed statements ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100519/2f50e4f9/attachment.pgp

#1 lore raw

Hi Mike,

Quoted 10 lines · Mike Frysinger

in reviewing some phy code i noticed that there's quite a good bit of duplication between miiphy.h and linux/mii.h. i imagine this is largely historical as miiphy.h dates back quite a long time, but moving forward, should we just do a mass conversion from the u-boot specific miiphy.h defines
to the more common linux/mii.h defines ? should be easy to do for most with a
few sed statements ...
-mike

I started down this path a while ago and then got distracted... When I last checked, the linux/mii.h was quite out of date wrt the kernel.org version, so if doing this we should update first. I agree that the current state is confusing and that miiphy is mainly a subset of linux.mii, with the same numbers but different mnemonics. Like you say, a simple sed script should do the trick.

regards,
Ben