Skip to contentSkip to conversation

misc: don't use sig->count

PATCH In review Oleg Nesterov 3 participants 5 messages Mar 23, 2010 – May 24, 2010

lore
Share & tools
lore
#0 lore raw

cover misc: don't use sig->count

Trivial.

According to grep, get_nr_threads() becomes the only user of sig->count.

Oleg.

#1 lore raw
Quoted 1 line · Oleg Nesterov

According to grep, get_nr_threads() becomes the only user of sig->count.

Are these two patches going upstream in this window?

David

#2 lore raw
Quoted 6 lines · David Howells
Quoted 1 line · Oleg Nesterov

According to grep, get_nr_threads() becomes the only user of sig->count.

Are these two patches going upstream in this window?

We should ask Andrew.

But personally I'd like to see them in 2.6.35. These changes allows us to do more cleanups/improvements.

As for sizeof(int) added to signal_struct. I still hope we can kill this "int nr_threads" later. Even if not, with these changes we can move, say, ->group_leader from task_struct to signal_struct and kill signal->leader_pid.

Oleg.

#3 lore raw
In reply to David Howells
Quoted 6 lines · On Fri, 21 May 2010 11:08:16 +0100 David Howells <[email protected]> wrote:
Quoted 1 line · Oleg Nesterov

According to grep, get_nr_threads() becomes the only user of sig->count.

Are these two patches going upstream in this window?

Sure, unless there's a reason not to do this?

#4 lore raw
Quoted 1 line · Andrew Morton

Sure, unless there's a reason not to do this?

Not that I know of. I was just checking (I'd like to get them out of my patch stack one way or another).

David