Skip to contentSkip to conversation

Improve DaVinci SPI speed

PATCH New Delio Brignoli 4 participants 16 messages May 13, 2010 – Jun 1, 2010 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Improve DaVinci SPI speed

Reduce the number of reads per byte transferred on the BUF register from 2 to 1 and take advantage of the TX buffer in the SPI module.

---
 drivers/spi/davinci_spi.c |   67 +++++++++++++++++++++++---------------------
 1 files changed, 35 insertions(+), 32 deletions(-)
drivers/spi/davinci_spi.c +35 -32
index 60ba007..b4a74de 100644
@@ -131,6 +131,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen,
 {
 	struct davinci_spi_slave *ds = to_davinci_spi(slave);
 	unsigned int	len, data1_reg_val = readl(&ds->regs->dat1);
+	unsigned int	i_cnt = 0, o_cnt = 0, buf_reg_val;
 	int		ret, i;
 	const u8	*txp = dout; /* dout can be NULL for read operation */
 	u8		*rxp = din;  /* din can be NULL for write operation */
@@ -159,41 +160,43 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen,
 	readl(&ds->regs->buf);
 
 	/* keep writing and reading 1 byte until done */
-	for (i = 0; i < len; i++) {
-		/* wait till TXFULL is asserted */
-		while (readl(&ds->regs->buf) & SPIBUF_TXFULL_MASK);
-
-		/* write the data */
-		data1_reg_val &= ~0xFFFF;
-		if (txp) {
-			data1_reg_val |= *txp;
-			txp++;
+	while((i_cnt < len) || (o_cnt < len)) {
+		/* read RX buffer and flags */
+		buf_reg_val = readl(&ds->regs->buf);
+
+		/* if data is available */
+		if ((i_cnt < len) && (buf_reg_val & SPIBUF_RXEMPTY_MASK) == 0) {
+			/* if there is no read buffer simply ignore the read character */
+			if(rxp) {
+				*rxp = buf_reg_val & 0xFF;	
+				rxp++;
+			}
+			/* increment read words count */
+			i_cnt++;
 		}
 
-		/*
-		 * Write to DAT1 is required to keep the serial transfer going.
-		 * We just terminate when we reach the end.
-		 */
-		if ((i == (len - 1)) && (flags & SPI_XFER_END)) {
-			/* clear CS hold */
-			writel(data1_reg_val &
-				~(1 << SPIDAT1_CSHOLD_SHIFT), &ds->regs->dat1);
-		} else {
-			/* enable CS hold */
-			data1_reg_val |= ((1 << SPIDAT1_CSHOLD_SHIFT) |
+		/* if the tx buffer is empty and there is still data to transmit */
+		if ((o_cnt < len) && ((buf_reg_val & SPIBUF_TXFULL_MASK) == 0)) {
+			/* write the data */
+			data1_reg_val &= ~0xFFFF;
+			if(txp) {
+				data1_reg_val |= *txp;
+				txp++;
+			}
+			/* write to DAT1 is required to keep the serial transfer going */
+			/* we just terminate when we reach the end */
+			if((o_cnt == (len -1)) && (flags & SPI_XFER_END)) {
+				/* clear CS hold */
+				writel(data1_reg_val &
+					~(1 << SPIDAT1_CSHOLD_SHIFT), &ds->regs->dat1);
+			} else {
+				/* enable CS hold and write TX register */
+				data1_reg_val |= ((1 << SPIDAT1_CSHOLD_SHIFT) |
 					(slave->cs << SPIDAT1_CSNR_SHIFT));
-			writel(data1_reg_val, &ds->regs->dat1);
-		}
-
-		/* read the data - wait for data availability */
-		while (readl(&ds->regs->buf) & SPIBUF_RXEMPTY_MASK);
-
-		if (rxp) {
-			*rxp = readl(&ds->regs->buf) & 0xFF;
-			rxp++;
-		} else {
-			/* simply drop the read character */
-			readl(&ds->regs->buf);
+				writel(data1_reg_val, &ds->regs->dat1);
+			}
+			/* increment written words count */
+			o_cnt++;
 		}
 	}
 	return 0;
Signature · 1 line
1.6.3.3
#1 lore raw

PATCH 1/1 Improve DaVinci SPI speed

Quoted 6 lines

Reduce the number of reads per byte transferred on the BUF register from 2 to 1 and
take advantage of the TX buffer in the SPI module.

May I ask which chip device this was tested on.

Quoted 106 lines
---
 drivers/spi/davinci_spi.c |   67 +++++++++++++++++++++++-----------------
----
 1 files changed, 35 insertions(+), 32 deletions(-)
drivers/spi/davinci_spi.c +1 -0
index 60ba007..b4a74de 100644
@@ -131,6 +131,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int
 bitlen,
 {
 	struct davinci_spi_slave *ds = to_davinci_spi(slave);
 	unsigned int	len, data1_reg_val = readl(&ds->regs->dat1);
+	unsigned int	i_cnt = 0, o_cnt = 0, buf_reg_val;
 	int		ret, i;
 	const u8	*txp = dout; /* dout can be NULL for read operation */
drivers/spi/davinci_spi.c +7 -9
 	u8		*rxp = din;  /* din can be NULL for write operation */
@@ -159,41 +160,43 @@ int spi_xfer(struct spi_slave *slave, unsigned int
 bitlen,
 	readl(&ds->regs->buf);
 
 	/* keep writing and reading 1 byte until done */
-	for (i = 0; i < len; i++) {
-		/* wait till TXFULL is asserted */
-		while (readl(&ds->regs->buf) & SPIBUF_TXFULL_MASK);
-
-		/* write the data */
-		data1_reg_val &= ~0xFFFF;
-		if (txp) {
-			data1_reg_val |= *txp;
-			txp++;
+	while((i_cnt < len) || (o_cnt < len)) {
+		/* read RX buffer and flags */
+		buf_reg_val = readl(&ds->regs->buf);
+
+		/* if data is available */
+		if ((i_cnt < len) && (buf_reg_val & SPIBUF_RXEMPTY_MASK) == 0)
 {
+			/* if there is no read buffer simply ignore the read

character */

drivers/spi/davinci_spi.c +7 -11
+			if(rxp) {
+				*rxp = buf_reg_val & 0xFF;
+				rxp++;
+			}
+			/* increment read words count */
+			i_cnt++;
 		}
 
-		/*
-		 * Write to DAT1 is required to keep the serial transfer going.
-		 * We just terminate when we reach the end.
-		 */
-		if ((i == (len - 1)) && (flags & SPI_XFER_END)) {
-			/* clear CS hold */
-			writel(data1_reg_val &
-				~(1 << SPIDAT1_CSHOLD_SHIFT), &ds->regs->dat1);
-		} else {
-			/* enable CS hold */
-			data1_reg_val |= ((1 << SPIDAT1_CSHOLD_SHIFT) |
+		/* if the tx buffer is empty and there is still data to

transmit */

drivers/spi/davinci_spi.c +1 -0
+		if ((o_cnt < len) && ((buf_reg_val & SPIBUF_TXFULL_MASK) ==

0)) {

drivers/spi/davinci_spi.c +7 -0
+			/* write the data */
+			data1_reg_val &= ~0xFFFF;
+			if(txp) {
+				data1_reg_val |= *txp;
+				txp++;
+			}
+			/* write to DAT1 is required to keep the serial transfer

going */

drivers/spi/davinci_spi.c +5 -0
+			/* we just terminate when we reach the end */
+			if((o_cnt == (len -1)) && (flags & SPI_XFER_END)) {
+				/* clear CS hold */
+				writel(data1_reg_val &
+					~(1 << SPIDAT1_CSHOLD_SHIFT), &ds->regs-
Quoted 1 line

dat1);

drivers/spi/davinci_spi.c +7 -13
+			} else {
+				/* enable CS hold and write TX register */
+				data1_reg_val |= ((1 << SPIDAT1_CSHOLD_SHIFT) |
 					(slave->cs << SPIDAT1_CSNR_SHIFT));
-			writel(data1_reg_val, &ds->regs->dat1);
-		}
-
-		/* read the data - wait for data availability */
-		while (readl(&ds->regs->buf) & SPIBUF_RXEMPTY_MASK);
-
-		if (rxp) {
-			*rxp = readl(&ds->regs->buf) & 0xFF;
-			rxp++;
-		} else {
-			/* simply drop the read character */
-			readl(&ds->regs->buf);
+				writel(data1_reg_val, &ds->regs->dat1);
+			}
+			/* increment written words count */
+			o_cnt++;
 		}
 	}
 	return 0;
--

1.6.3.3

#2 lore raw

PATCH 1/1 Improve DaVinci SPI speed

Hello Paulraj,

Quoted 5 lines · Sandeep
Quoted 3 lines

Reduce the number of reads per byte transferred on the BUF register from 2 to 1 and
take advantage of the TX buffer in the SPI module.

May I ask which chip device this was tested on.

Sure, it was tested on a LogicPD Zoom? OMAP-L138 eXperimenter Kit (da850_omapl138_evm_config).

--
Delio

Quoted 106 lines
Quoted 105 lines

---
drivers/spi/davinci_spi.c | 67 +++++++++++++++++++++++-----------------
----

1 files changed, 35 insertions(+), 32 deletions(-)
drivers/spi/davinci_spi.c +1 -0
index 60ba007..b4a74de 100644
@@ -131,6 +131,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int
 bitlen,
 {
 	struct davinci_spi_slave *ds = to_davinci_spi(slave);
 	unsigned int	len, data1_reg_val = readl(&ds->regs->dat1);
+	unsigned int	i_cnt = 0, o_cnt = 0, buf_reg_val;
 	int		ret, i;
 	const u8	*txp = dout; /* dout can be NULL for read operation */

u8 *rxp = din; /* din can be NULL for write operation */

drivers/spi/davinci_spi.c +7 -9
@@ -159,41 +160,43 @@ int spi_xfer(struct spi_slave *slave, unsigned int
 bitlen,
 	readl(&ds->regs->buf);
 
 	/* keep writing and reading 1 byte until done */
-	for (i = 0; i < len; i++) {
-		/* wait till TXFULL is asserted */
-		while (readl(&ds->regs->buf) & SPIBUF_TXFULL_MASK);
-
-		/* write the data */
-		data1_reg_val &= ~0xFFFF;
-		if (txp) {
-			data1_reg_val |= *txp;
-			txp++;
+	while((i_cnt < len) || (o_cnt < len)) {
+		/* read RX buffer and flags */
+		buf_reg_val = readl(&ds->regs->buf);
+
+		/* if data is available */
+		if ((i_cnt < len) && (buf_reg_val & SPIBUF_RXEMPTY_MASK) == 0)
 {
+			/* if there is no read buffer simply ignore the read

character */

drivers/spi/davinci_spi.c +6 -0
+			if(rxp) {
+				*rxp = buf_reg_val & 0xFF;
+				rxp++;
+			}
+			/* increment read words count */
+			i_cnt++;
		}
drivers/spi/davinci_spi.c +1 -11
-		/*
-		 * Write to DAT1 is required to keep the serial transfer going.
-		 * We just terminate when we reach the end.
-		 */
-		if ((i == (len - 1)) && (flags & SPI_XFER_END)) {
-			/* clear CS hold */
-			writel(data1_reg_val &
-				~(1 << SPIDAT1_CSHOLD_SHIFT), &ds->regs->dat1);
-		} else {
-			/* enable CS hold */
-			data1_reg_val |= ((1 << SPIDAT1_CSHOLD_SHIFT) |
+		/* if the tx buffer is empty and there is still data to

transmit */

drivers/spi/davinci_spi.c +1 -0
+		if ((o_cnt < len) && ((buf_reg_val & SPIBUF_TXFULL_MASK) ==

0)) {

drivers/spi/davinci_spi.c +7 -0
+			/* write the data */
+			data1_reg_val &= ~0xFFFF;
+			if(txp) {
+				data1_reg_val |= *txp;
+				txp++;
+			}
+			/* write to DAT1 is required to keep the serial transfer

going */

drivers/spi/davinci_spi.c +5 -0
+			/* we just terminate when we reach the end */
+			if((o_cnt == (len -1)) && (flags & SPI_XFER_END)) {
+				/* clear CS hold */
+				writel(data1_reg_val &
+					~(1 << SPIDAT1_CSHOLD_SHIFT), &ds->regs-
Quoted 1 line

dat1);

drivers/spi/davinci_spi.c +3 -0
+			} else {
+				/* enable CS hold and write TX register */
+				data1_reg_val |= ((1 << SPIDAT1_CSHOLD_SHIFT) |
					(slave->cs << SPIDAT1_CSNR_SHIFT));
drivers/spi/davinci_spi.c +4 -12
-			writel(data1_reg_val, &ds->regs->dat1);
-		}
-
-		/* read the data - wait for data availability */
-		while (readl(&ds->regs->buf) & SPIBUF_RXEMPTY_MASK);
-
-		if (rxp) {
-			*rxp = readl(&ds->regs->buf) & 0xFF;
-			rxp++;
-		} else {
-			/* simply drop the read character */
-			readl(&ds->regs->buf);
+				writel(data1_reg_val, &ds->regs->dat1);
+			}
+			/* increment written words count */
+			o_cnt++;
		}
	}
	return 0;

--
1.6.3.3

#3 lore raw

PATCH 1/1 Improve DaVinci SPI speed

Quoted 11 lines

Hello Paulraj,

Quoted 1 line · Sandeep
Quoted 1 line

Reduce the number of reads per byte transferred on the BUF register

from 2

Quoted 3 lines
Quoted 2 lines

to 1 and
take advantage of the TX buffer in the SPI module.

Quoted 6 lines
Quoted 1 line

May I ask which chip device this was tested on.

Sure, it was tested on a LogicPD Zoom(tm) OMAP-L138 eXperimenter Kit (da850_omapl138_evm_config).

--

If nobody has objections then I will apply it this weekend to u-boot-ti

The reason for asking which board/SOC was because I don't have that EVM.

#4 lore raw

PATCH 1/1 Improve DaVinci SPI speed

Hi Sandeep,

Quoted 11 lines · Sandeep
Quoted 11 lines

Hello Paulraj,

Quoted 1 line · Sandeep
Quoted 1 line

Reduce the number of reads per byte transferred on the BUF register

from 2

Quoted 3 lines
Quoted 2 lines

to 1 and
take advantage of the TX buffer in the SPI module.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

May I ask which chip device this was tested on.

Sure, it was tested on a LogicPD Zoom(tm) OMAP-L138 eXperimenter Kit (da850_omapl138_evm_config).

--

If nobody has objections then I will apply it this weekend to u-boot-ti

I am yet to review this (came in only yesterday evening). Can you please wait till early next week before applying it.

Thanks,
Sekhar

#5 lore raw

PATCH 1/1 Improve DaVinci SPI speed

In reply to Delio Brignoli

Hi Delio,

Quoted 2 lines · Delio Brignoli

Reduce the number of reads per byte transferred on the BUF register from 2 to 1 and take advantage of the TX buffer in the SPI module.

The patch looks good to me.

Can you please publish some sort of numbers in the patch description indicating the performance improvement achieved?

A minor nit below:

Quoted 12 lines
---
 drivers/spi/davinci_spi.c |   67 +++++++++++++++++++++++---------------------
 1 files changed, 35 insertions(+), 32 deletions(-)
drivers/spi/davinci_spi.c +0 -0
index 60ba007..b4a74de 100644
@@ -131,6 +131,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen,
 {

[...]

drivers/spi/davinci_spi.c int spi_xfer(struct spi_slave *slave, unsigned int bitlen, · line 188

Quoted 3 lines
drivers/spi/davinci_spi.c +3 -0
+                     /* write to DAT1 is required to keep the serial transfer going */
+                     /* we just terminate when we reach the end */
+                     if((o_cnt == (len -1)) && (flags & SPI_XFER_END)) {

Please include a space before the '-'

Thanks,
Sekhar

#6 lore raw

PATCH 1/1 Improve DaVinci SPI speed

Hello Sekhar,

Quoted 5 lines · Sekhar

The patch looks good to me.

Can you please publish some sort of numbers in the patch description indicating the performance improvement achieved?

will do.

Quoted 1 line

A minor nit below:

[...]

Quoted 3 lines
Quoted 1 line

+ if((o_cnt == (len -1)) && (flags & SPI_XFER_END)) {

Please include a space before the '-'

Thanks
--
Delio

Quoted 4 lines

Thanks,
Sekhar

#7 lore raw

PATCH 1/1 Improve DaVinci SPI speed

In reply to Nori

Hello Sekhar,

I resubmitted the patch a few days ago (13th of May) with the changes you requested. Please ack it, so it can be applied.

Thanks
--
Delio

Quoted 36 lines · Sekhar
Quoted 2 lines · Delio Brignoli

Reduce the number of reads per byte transferred on the BUF register from 2 to 1 and take advantage of the TX buffer in the SPI module.

The patch looks good to me.

Can you please publish some sort of numbers in the patch description indicating the performance improvement achieved?

A minor nit below:

Quoted 12 lines

---
drivers/spi/davinci_spi.c | 67 +++++++++++++++++++++++---------------------

1 files changed, 35 insertions(+), 32 deletions(-)
drivers/spi/davinci_spi.c +0 -0
index 60ba007..b4a74de 100644
@@ -131,6 +131,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen,
 {

[...]

drivers/spi/davinci_spi.c int spi_xfer(struct spi_slave *slave, unsigned int bitlen, · line 188

Quoted 3 lines
drivers/spi/davinci_spi.c +3 -0
+                     /* write to DAT1 is required to keep the serial transfer going */
+                     /* we just terminate when we reach the end */
+                     if((o_cnt == (len -1)) && (flags & SPI_XFER_END)) {

Please include a space before the '-'

Thanks,
Sekhar

#8 lore raw

PATCH 1/1 Improve DaVinci SPI speed

In reply to Delio Brignoli

Dear Delio Brignoli,

Quoted 2 lines · In message <[email protected]> you wrote:

Reduce the number of reads per byte transferred on the BUF register from 2 to 1 and take advantage of the TX buffer in the SPI module.

...

drivers/spi/davinci_spi.c int spi_xfer(struct spi_slave *slave, unsigned int bitlen, · line 173

Quoted 7 lines
drivers/spi/davinci_spi.c +7 -0
+		/* if data is available */
+		if ((i_cnt < len) && (buf_reg_val & SPIBUF_RXEMPTY_MASK) == 0) {
+			/* if there is no read buffer simply ignore the read character */
+			if(rxp) {
+				*rxp = buf_reg_val & 0xFF;	
+				rxp++;
+			}

Please change into:

			if (rxp)
				*rxp++ = buf_reg_val & 0xFF;

drivers/spi/davinci_spi.c int spi_xfer(struct spi_slave *slave, unsigned int bitlen, · line 185

Quoted 7 lines
drivers/spi/davinci_spi.c +7 -0
+		if ((o_cnt < len) && ((buf_reg_val & SPIBUF_TXFULL_MASK) == 0)) {
+			/* write the data */
+			data1_reg_val &= ~0xFFFF;
+			if(txp) {
+				data1_reg_val |= *txp;
+				txp++;
+			}

Same here:

			if (txp)
				data1_reg_val |= *txp++;

Please fix all other occurrences of "if(" into "if (" as well.

drivers/spi/davinci_spi.c int spi_xfer(struct spi_slave *slave, unsigned int bitlen, · line 187

Quoted 2 lines
drivers/spi/davinci_spi.c +2 -0
+			/* write to DAT1 is required to keep the serial transfer going */
+			/* we just terminate when we reach the end */

Incorrect multiline comment style.

drivers/spi/davinci_spi.c int spi_xfer(struct spi_slave *slave, unsigned int bitlen, · line 191

Quoted 2 lines
drivers/spi/davinci_spi.c +2 -0
+				writel(data1_reg_val &
+					~(1 << SPIDAT1_CSHOLD_SHIFT), &ds->regs->dat1);

Line too long.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
 The software required `Windows 95 or better', so I installed Linux.
#9 lore raw

PATCH 1/1 Improve DaVinci SPI speed

Hello Wolfgang,

Quoted 8 lines · Wolfgang Denk

drivers/spi/davinci_spi.c int spi_xfer(struct spi_slave *slave, unsigned int bitlen, · line 173

Quoted 3 lines
drivers/spi/davinci_spi.c +3 -0
+				*rxp = buf_reg_val & 0xFF;	
+				rxp++;
+			}

Please change into:

			if (rxp)
				*rxp++ = buf_reg_val & 0xFF;

Are you sure? Is folding that 3 line block into a one liner really worth the loss of readability? I know what that means, so do you and many others on this ML, but that's bound to raise a few eyebrows. A quick google search reveals quite a few articles devoted to clearing up the confusion about the semantics of that pointer dereference and post-increment. Just a few years ago I would have preferred your suggestion, but now I find that readability trumps cleverness, at least in a case like this. In the end it's your decision: if you like to be kinky, it's your prerogative ;-)

Quoted 11 lines

drivers/spi/davinci_spi.c int spi_xfer(struct spi_slave *slave, unsigned int bitlen, · line 185

Quoted 8 lines
drivers/spi/davinci_spi.c +7 -0
+		if ((o_cnt < len) && ((buf_reg_val & SPIBUF_TXFULL_MASK) == 0)) {
+			/* write the data */
+			data1_reg_val &= ~0xFFFF;
+			if(txp) {
+				data1_reg_val |= *txp;
+				txp++;
+			}

Same here:

Quoted 2 lines
			if (txp)
				data1_reg_val |= *txp++;

See my comment above.

Quoted 1 line

Please fix all other occurrences of "if(" into "if (" as well.

OK

Quoted 3 lines

drivers/spi/davinci_spi.c int spi_xfer(struct spi_slave *slave, unsigned int bitlen, · line 187

Quoted 3 lines
drivers/spi/davinci_spi.c +2 -0
+			/* write to DAT1 is required to keep the serial transfer going */
+			/* we just terminate when we reach the end */

will fix

Quoted 4 lines

drivers/spi/davinci_spi.c int spi_xfer(struct spi_slave *slave, unsigned int bitlen, · line 191

Quoted 2 lines
drivers/spi/davinci_spi.c +2 -0
+				writel(data1_reg_val &
+					~(1 << SPIDAT1_CSHOLD_SHIFT), &ds->regs->dat1);

Line too long.

ditto

Thanks for the feedback
--
Delio

Quoted 13 lines

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The software required `Windows 95 or better', so I installed Linux.
#10 lore raw

PATCH 1/1 Improve DaVinci SPI speed

Dear Delio Brignoli,

Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 6 lines · Wolfgang Denk

drivers/spi/davinci_spi.c int spi_xfer(struct spi_slave *slave, unsigned int bitlen, · line 173

Quoted 3 lines
drivers/spi/davinci_spi.c +3 -0
+				*rxp = buf_reg_val & 0xFF;	
+				rxp++;
+			}

Please change into:

Quoted 6 lines
Quoted 2 lines
			if (rxp)
				*rxp++ = buf_reg_val & 0xFF;

Are you sure? Is folding that 3 line block into a one liner really worth the loss of readability? I know what that means, so do you and many others on this ML, but that's bound to raise a few eyebrows. A quick

Removing the need for braces is a good thing.

This is plain C, without any tricks or loopholes.

Quoted 2 lines

in a case like this. In the end it's your decision: if you like to be kinky, it's your prerogative ;-)

Kinky? Funny how you see that.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Build a system that even a fool can use and only a fool will want  to
use it.
#11 lore raw

PATCH 1/1 Improve DaVinci SPI speed

Hello Wolfgang,

Quoted 9 lines · Wolfgang Denk
Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 6 lines · Wolfgang Denk

drivers/spi/davinci_spi.c int spi_xfer(struct spi_slave *slave, unsigned int bitlen, · line 173

Quoted 3 lines
drivers/spi/davinci_spi.c +3 -0
+				*rxp = buf_reg_val & 0xFF;	
+				rxp++;
+			}

Please change into:

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
			if (rxp)
				*rxp++ = buf_reg_val & 0xFF;

Are you sure? Is folding that 3 line block into a one liner really worth the loss of readability? I know what that means, so do you and many others on this ML, but that's bound to raise a few eyebrows. A quick

Removing the need for braces is a good thing.

by making the code less intelligible, which is a bad thing.

Quoted 1 line

This is plain C, without any tricks or loopholes.

This is C, the hard-to-read kind, but you refuse to acknowledge that by stating only your side of the argument, while I pointed out the tradeoff involved and my opinion. I have no inclination to argue in this fashion :-)

Kind Regards
--
Delio

Quoted 11 lines

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Build a system that even a fool can use and only a fool will want  to
use it.
#12 lore raw

PATCH 1/1 Improve DaVinci SPI speed

In reply to Delio Brignoli

Hi Delio,

Quoted 7 lines · Delio Brignoli

Hello Wolfgang,

Quoted 4 lines · Wolfgang Denk
Quoted 3 lines
drivers/spi/davinci_spi.c +3 -0
+                          *rxp = buf_reg_val & 0xFF;
+                          rxp++;
+                  }
Quoted 7 lines
Quoted 4 lines

Please change into:

                    if (rxp)
                            *rxp++ = buf_reg_val & 0xFF;

Are you sure? Is folding that 3 line block into a one liner really worth the loss of readability? I know what that means, so do you and many others on this ML, but that's bound to raise a few eyebrows. A quick google search reveals quite a few articles devoted to clearing up the confusion about the semantics of that pointer dereference and post-increment. Just a few years ago I would have preferred your suggestion, but now I find that readability trumps cleverness, at least in a case like this. In the end it's your decision: if you like to be kinky, it's your prerogative ;-)

Looking for the pointer de-reference and increment expression in Linux kernel, I had ~4500 hits and ~600 hits in U-Boot. So, may be this is not such an uncommon expression after all (at least in the kernel/U-Boot world).

Considering this, can you please accept the change Wolfgang is asking for for so this useful patch can move forward?

After all, code readability is also about pattern matching in the mind and if developers are already used to seeing this expression not many would find it odd.

Thanks,
Sekhar

#13 lore raw

PATCH 1/1 Improve DaVinci SPI speed

Hello Sekhar,

On 01/06/2010, at 12:18, Nori, Sekhar wrote:
[...]

Quoted 2 lines

Considering this, can you please accept the change Wolfgang is asking for for so this useful patch can move forward?

Yes, I am fine applying the changes Wolfgang requested. I have been busy working on other stuff, hence the delay. Will be posting the updated patch shortly.

Thanks
--
Delio

#14 lore raw

PATCH 1/1 DaVinci: Improve DaVinci SPI speed.

In reply to Delio Brignoli
Quoted 5 lines · Delio Brignoli

Reduce the number of reads per byte transferred on the BUF register from 2 to 1 and take advantage of the TX buffer in the SPI module. On LogicPD OMAP-L138 EVM, SPI read throughput goes up from ~0.8Mbyte/s to ~1.3Mbyte/s. Tested with a 2Mbyte image file.

Applies cleanly on u-boot master branch -- 2f05e39 of
git://git.denx.de/u-boot.git

Applies cleanly and compiles with da850evm_config on u-boot-omap-l1 master branch -- 5f16b85 of 2f05e39 . Also running the resulting u-boot.bin did show a noticeable improvement in kernel load time.

Signature · 4 lines
Ben Gardiner
Nanometrics Inc.
+1 (613) 592-6776 x239
http://www.nanometrics.ca
#15 lore raw

PATCH 1/1 DaVinci: Improve DaVinci SPI speed.

Quoted 2 lines · Ben Gardiner

Applies cleanly and compiles with da850evm_config on u-boot-omap-l1 master branch -- 5f16b85 of 2f05e39 . Also running the resulting

Sorry, that should be 5f16b85 of
git://arago-project.org/git/people/sekhar/u-boot-omapl1.git .

Signature · 4 lines
Ben Gardiner
Nanometrics Inc.
+1 (613) 592-6776 x239
http://www.nanometrics.ca