Skip to contentSkip to conversation

sctp: dubious bitfields in sctp_transport

PATCH Applied Dan Carpenter 3 participants 3 messages May 22, 2010 – May 26, 2010

Subsystems (4)
Networking Network drivers Kernel janitors SCTP protocol
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 sctp: dubious bitfields in sctp_transport

Sparse complains because these one-bit bitfields are signed.
include/net/sctp/structs.h:879:24: error: dubious one-bit signed bitfield include/net/sctp/structs.h:889:31: error: dubious one-bit signed bitfield include/net/sctp/structs.h:895:26: error: dubious one-bit signed bitfield include/net/sctp/structs.h:898:31: error: dubious one-bit signed bitfield include/net/sctp/structs.h:901:27: error: dubious one-bit signed bitfield

It doesn't cause a problem in the current code, but it would be better to clean it up. This was introduced by c0058a35aacc7: "sctp: Save some room in the sctp_transport by using bitfields".

Signed-off-by Dan Carpenter <[email protected]>

---
It looks like this header is exported to user space. I don't know if that makes a difference.

include/net/sctp/structs.h +1 -1
index 6173c61..4b86011 100644
@@ -876,7 +876,7 @@ struct sctp_transport {
 
 	/* Reference counting. */
 	atomic_t refcnt;
-	int	 dead:1,
+	__u32	 dead:1,
 		/* RTO-Pending : A flag used to track if one of the DATA
 		 *		chunks sent to this address is currently being
 		 *		used to compute a RTT. If this flag is 0,
#1 lore raw
Quoted 7 lines · Dan Carpenter

Sparse complains because these one-bit bitfields are signed.
include/net/sctp/structs.h:879:24: error: dubious one-bit signed bitfield include/net/sctp/structs.h:889:31: error: dubious one-bit signed bitfield include/net/sctp/structs.h:895:26: error: dubious one-bit signed bitfield include/net/sctp/structs.h:898:31: error: dubious one-bit signed bitfield include/net/sctp/structs.h:901:27: error: dubious one-bit signed bitfield

Quoted 8 lines

It doesn't cause a problem in the current code, but it would be better to clean it up. This was introduced by c0058a35aacc7: "sctp: Save some room in the sctp_transport by using bitfields".

Signed-off-by Dan Carpenter <[email protected]>

---
It looks like this header is exported to user space. I don't know if that makes a difference.

That shouldn't make a difference.

-vlad

Quoted 15 lines
include/net/sctp/structs.h +1 -1
index 6173c61..4b86011 100644
@@ -876,7 +876,7 @@ struct sctp_transport {
 
 	/* Reference counting. */
 	atomic_t refcnt;
-	int	 dead:1,
+	__u32	 dead:1,
 		/* RTO-Pending : A flag used to track if one of the DATA
 		 *		chunks sent to this address is currently being
 		 *		used to compute a RTT. If this flag is 0,
maintainer Applied
#2 lore raw
In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>
Date: Sat, 22 May 2010 22:20:24 +0200

Quoted 7 lines

Sparse complains because these one-bit bitfields are signed.
include/net/sctp/structs.h:879:24: error: dubious one-bit signed bitfield include/net/sctp/structs.h:889:31: error: dubious one-bit signed bitfield include/net/sctp/structs.h:895:26: error: dubious one-bit signed bitfield include/net/sctp/structs.h:898:31: error: dubious one-bit signed bitfield include/net/sctp/structs.h:901:27: error: dubious one-bit signed bitfield

Quoted 5 lines

It doesn't cause a problem in the current code, but it would be better to clean it up. This was introduced by c0058a35aacc7: "sctp: Save some room in the sctp_transport by using bitfields".

Signed-off-by Dan Carpenter <[email protected]>

Applied, thanks Dan.