scsi/qla2xxx: fix end of loop test

PATCH New Dan Carpenter 1 participant 1 message May 22, 2010

Subsystems (3)

SCSI Kernel janitors QLogic QLA2XXX FC-SCSI driver

lore

Share & tools

lore

Dan Carpenter

author

2010-05-22 20:37 UTC #0 lore raw

PATCH 1/1 scsi/qla2xxx: fix end of loop test

The "fcport" variable is never null here. I've updated the condition to test for the end of the list_for_each_entry() loop.

Signed-off-by Dan Carpenter <[email protected]>

drivers/scsi/qla2xxx/qla_bsg.c +1 -1

index b905dfe..14ca275 100644
@@ -1050,7 +1050,7 @@ qla24xx_iidma(struct fc_bsg_job *bsg_job)
 		break;
 	}
 
-	if (!fcport) {
+	if (&fcport->list = &vha->vp_fcports) {
 		DEBUG2(printk(KERN_ERR "%s(%ld): Failed to find port\n",
 			__func__, vha->host_no));
 		return -EINVAL;