Skip to contentSkip to conversation

calgary: Increase the maximum PHB bus number

PATCH Corinna Schultz 1 participant 1 message May 24, 2010

lore
Share & tools
lore
#0 lore raw
Quoted 20 lines · Darrick J. Wong
Quoted 19 lines · Darrick J. Wong
Quoted 18 lines · Muli Ben-Yehuda
Quoted 14 lines · Darrick J. Wong
Quoted 1 line
Quoted 1 line

-#define MAX_NUM_OF_PHBS 8 /* how many PHBs in total? */

(quoted diff) +9 -3
-#define MAX_NUM_CHASSIS		 		 8 /* max number of chassis */
-/* MAX_PHB_BUS_NUM is the maximal possible dev->bus->number */
-#define MAX_PHB_BUS_NUM		 		 (MAX_NUM_OF_PHBS * MAX_NUM_CHASSIS * 2)
+/*
+   The maximum PHB bus number.
+   x3950M2 (rare): 8 chassis, 48 PHBs per chassis = 384
+   x3950M2: 4 chassis, 48 PHBs per chassis        = 192
+   x3950 (PCIE): 8 chassis, 32 PHBs per chassis   = 256
+   x3950 (PCIX): 8 chassis, 16 PHBs per chassis   = 128
+*/
+#define MAX_PHB_BUS_NUM		 		 384
+
 #define PHBS_PER_CALGARY		 4
Quoted 1 line
Quoted 1 line

We'll end up wasting a few bytes on small systems, but I don't think

it's enough to matter on these fairly large systems. As far as I'm concerned, patch is fine.

Quoted 7 lines
Quoted 3 lines
Quoted 2 lines
Quoted 1 line
Quoted 1 line

Hmm... has this patch been queued up by anyone for the .34 merge

window?

Still not in 2.6.34-rc3. Are there any objections to this patch? I've not heard any complaints since my original posting... or did it simply get lost in
the noise?

This patch still hasn't been picked up by a maintainer.

Are there any objections?

-Corinna Schultz
IBM LTC