net/core: use net_device dev_id to indicate port number
Subsystems (3)
PATCH 1/1 net/core: use net_device dev_id to indicate port number
Today, there are no means to know which port of a hardware device a netdev interface uses. struct net_device conatins a field, dev_id, that can be used for that. This patch adds a new macro, SET_NETDEV_DEV_ID(), to provide a standard way to set the value of this field.
Also also make use of this feature in the mlx4_en driver to set the port number; port numbers are zero based.
--- drivers/net/mlx4/en_netdev.c | 1 + include/linux/netdevice.h | 5 +++++ 2 files changed, 6 insertions(+), 0 deletions(-)
drivers/net/mlx4/en_netdev.c +1 -0
@@ -978,6 +978,7 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port, }SET_NETDEV_DEV (dev, &mdev->dev->pdev->dev); +SET_NETDEV_DEV_ID (dev, port -1 );/* * Initialize driver private data
include/linux/netdevice.h +5 -0
@@ -1080,6 +1080,11 @@ static inline void *netdev_priv(const struct net_device *dev)*/ #define SET_NETDEV_DEVTYPE (net, devtype) ((net)->dev.type = (devtype)) +/* +* Set the port number of the physical device that this port net device uses +*/ +#define SET_NETDEV_DEV_ID (net, devid) ((net)->dev_id = (devid)) +/** * netif_napi_add - initialize a napi context * @dev: network device
Signature · 1 line
1.7.1
A message that is not in the archive (sent off-list or not yet received): 20100526095200.GA7370-8YAHvHwT2UEvbXDkjdHOrw/[email protected]
Quoted 6 lines · On Wed, 26 May 2010 12:52:00 +0300 Eli Cohen…
Today, there are no means to know which port of a hardware device a netdev interface uses. struct
net_deviceconatins a field,dev_id, that can be used for that. This patch adds a new macro,SET_NETDEV_DEV_ID(), to provide a standard way to set the value of this field.
Also also make use of this feature in themlx4_endriver to set the port number; port numbers are zero based.
Why is a macro wrapper needed?
Signature · 4 lines
-- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 12 lines · Stephen Hemminger
Quoted 6 lines · On Wed, 26 May 2010 12:52:00 +0300 Eli Cohen <[email protected]> wrote:
Today, there are no means to know which port of a hardware device a netdev interface uses. struct
net_deviceconatins a field,dev_id, that can be used for that. This patch adds a new macro,SET_NETDEV_DEV_ID(), to provide a standard way to set the value of this field.
Also also make use of this feature in themlx4_endriver to set the port number; port numbers are zero based.Why is a macro wrapper needed?
I guess for the same reason we use SET_NETDEV_DEV - to provide a consistent interface for setting this value...
Quoted 11 lines · On Wed, 26 May 2010 18:27:30 +0300 Eli Cohen <[email protected]> wrote:
Quoted 10 lines · Stephen Hemminger
Quoted 6 lines · On Wed, 26 May 2010 12:52:00 +0300 Eli Cohen <[email protected]> wrote:
Today, there are no means to know which port of a hardware device a netdev interface uses. struct
net_deviceconatins a field,dev_id, that can be used for that. This patch adds a new macro,SET_NETDEV_DEV_ID(), to provide a standard way to set the value of this field.
Also also make use of this feature in themlx4_endriver to set the port number; port numbers are zero based.
Quoted 5 lines
Quoted 2 lines
Why is a macro wrapper needed?
I guess for the same reason we use
SET_NETDEV_DEV- to provide a consistent interface for setting this value...
SET_NETDEV_DEV macro exists because at the time 2.5 kernel was being developed it was important to be able to maintain source compatibility between 2.4 and 2.6 (nee 2.5) drivers. Since 2.4 did not have sysfs, the macro was a mechanism to allow the same code to run on both kernel versions.
Your situation is different, just use dev_id and update documentation if you need to.
Quoted 9 lines · Stephen Hemminger
SET_NETDEV_DEVmacro exists because at the time 2.5 kernel was being developed it was important to be able to maintain source compatibility between 2.4 and 2.6 (nee 2.5) drivers. Since 2.4 did not have sysfs, the macro was a mechanism to allow the same code to run on both kernel versions.Your situation is different, just use
dev_idand update documentation if you need to.
OK, great. Things get much much simpler :-)
I'll send another patch for mlx4_en only.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html