Skip to contentSkip to conversation

Name of event-channel and other devices vs. udev

PATCH In review Bastian Blank 5 participants 15 messages May 26, 2010 – May 28, 2010 Xen hypervisor interface

lore
Share & tools
lore
#0 lore raw

Hi

Currently udev overwrites the name of the event-channel device to /dev/xen/evtchn. This approach is about to be discontinued and needs to be fixed on either side.

| udevd-work[549]: kernel-provided name 'evtchn' and NAME= 'xen/evtchn' disagree, please use SYMLINK+= or change the kernel to provide the proper name

There are several fixes for that:
- Make the kernel name the device "xen/evtchn".
- Remove the rule and convert to another name. Either /dev/evtchn, which is a bit to generic or something like xen-evtchn.

The first should be the more compatible one.

Bastian

Signature · 2 lines
A princess should not be afraid -- not with a brave knight to protect her.
		-- McCoy, "Shore Leave", stardate 3025.3
#1 lore raw
Quoted 6 lines · Bastian Blank

Hi

Currently udev overwrites the name of the event-channel device to /dev/xen/evtchn. This approach is about to be discontinued and needs to be fixed on either side.

Quoted 9 lines

| udevd-work[549]: kernel-provided name 'evtchn' and NAME= 'xen/evtchn' disagree, please use SYMLINK+= or change the kernel to provide the proper name

There are several fixes for that:
- Make the kernel name the device "xen/evtchn".
- Remove the rule and convert to another name. Either /dev/evtchn, which is a bit to generic or something like xen-evtchn.

The first should be the more compatible one.

Yep, looks reasonable to me.

J

#2 lore raw
In reply to Bastian Blank
Quoted 5 lines · Bastian Blank

Currently udev overwrites the name of the event-channel device to /dev/xen/evtchn. This approach is about to be discontinued and needs to be fixed on either side.
There are several fixes for that:
- Make the kernel name the device "xen/evtchn".

This approach somewhat reliable failed for me[1]. Also nothing else in the kernel uses it. So I assume this is not really supported.

Quoted 2 lines

- Remove the rule and convert to another name. Either /dev/evtchn, which is a bit to generic or something like xen-evtchn.

So this is the only solution, and the kernel usually uses _ as delimiter for devices, so "xen_evtchn" is the name to use. And make xen/evtchn a symlink for backward compatibility.

Bastian

[1]: http://bugs.debian.org/583283

Signature · 2 lines
Conquest is easy. Control is not.
		-- Kirk, "Mirror, Mirror", stardate unknown
#3 lore raw
Quoted 4 lines · Bastian Blank
Quoted 1 line · Bastian Blank

- Make the kernel name the device "xen/evtchn".

This approach somewhat reliable failed for me[1]. Also nothing else in the kernel uses it. So I assume this is not really supported.

Xen themself is responsible for this behaviour.

Quoted 1 line

[1]: http://bugs.debian.org/583283

Bastian

Signature · 2 lines
I'm a soldier, not a diplomat.  I can only tell the truth.
		-- Kirk, "Errand of Mercy", stardate 3198.9
#4 lore raw

PATCH 1/1 Fix name of Xen event-channel device

The Xen event-channel device is named evtchn in the kernel but always used as /dev/xen/evtchn in userspace. This patch fixes the name.

drivers/xen/evtchn.c +1 -1
index 66e185c..89cd743 100644
@@ -471,7 +471,7 @@ static const struct file_operations evtchn_fops = {
 
 static struct miscdevice evtchn_miscdev = {
 	.minor        = MISC_DYNAMIC_MINOR,
-	.name         = "evtchn",
+	.name         = "xen/evtchn",
 	.fops         = &evtchn_fops,
 };
 static int __init evtchn_init(void)
Signature · 2 lines
Yes, it is written.  Good shall always destroy evil.
		-- Sirah the Yang, "The Omega Glory", stardate unknown
#5 lore raw

Re: [Xen-devel] [PATCH] Fix name of Xen event-channel device

Quoted 2 lines · Bastian Blank

The Xen event-channel device is named evtchn in the kernel but always used as /dev/xen/evtchn in userspace. This patch fixes the name.

Hey Bastian,

Is this related to this bug:
http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1612 ?

I saw it in some reference to the evtchn but wasn't sure if this is the same.

Quoted 24 lines
drivers/xen/evtchn.c +1 -1
index 66e185c..89cd743 100644
@@ -471,7 +471,7 @@ static const struct file_operations evtchn_fops = {
 
 static struct miscdevice evtchn_miscdev = {
 	.minor        = MISC_DYNAMIC_MINOR,
-	.name         = "evtchn",
+	.name         = "xen/evtchn",
 	.fops         = &evtchn_fops,
 };
 static int __init evtchn_init(void)
Signature · 7 lines
Yes, it is written.  Good shall always destroy evil.
		-- Sirah the Yang, "The Omega Glory", stardate unknown

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
#6 lore raw

Re: [PATCH] Fix name of Xen event-channel device

In reply to Bastian Blank
Quoted 10 lines · Bastian Blank

The Xen event-channel device is named evtchn in the kernel but always used as /dev/xen/evtchn in userspace. This patch fixes the name.

drivers/xen/evtchn.c +0 -0
index 66e185c..89cd743 100644

drivers/xen/evtchn.c static const struct file_operations evtchn_fops = { · line 474

Quoted 5 lines
drivers/xen/evtchn.c +1 -1
@@ -471,7 +471,7 @@ static const struct file_operations evtchn_fops = {
 
 static struct miscdevice evtchn_miscdev = {
 	.minor        = MISC_DYNAMIC_MINOR,
-	.name         = "evtchn",
+	.name         = "xen/evtchn",

Um. Will existing userspace - esp. udev rules - continue to work after this change? Also, how about other xen-related devices which are moved to /dev/xen in that same udev rules?

Thanks!

/mjt

#7 lore raw

Re: [PATCH] Fix name of Xen event-channel device

Quoted 12 lines · Michael Tokarev
Quoted 11 lines · Bastian Blank

The Xen event-channel device is named evtchn in the kernel but always used as /dev/xen/evtchn in userspace. This patch fixes the name.

drivers/xen/evtchn.c +0 -0
index 66e185c..89cd743 100644
@@ -471,7 +471,7 @@ static const struct file_operations evtchn_fops = {
 
Quoted 7 lines

drivers/xen/evtchn.c static const struct file_operations evtchn_fops = { · line 474

Quoted 4 lines
drivers/xen/evtchn.c +1 -1
 static struct miscdevice evtchn_miscdev = {
 	.minor        = MISC_DYNAMIC_MINOR,
-	.name         = "evtchn",
+	.name         = "xen/evtchn",

Um. Will existing userspace - esp. udev rules - continue to work after this change?

The udev rules will just not longer match, as they only rename the device, this is no problem. However libxc _will_ break, as it lacks proper error check in its own device creation routine.

However there are not much possibilities here: this support will go away and it will annoy every user for some time.

Quoted 2 lines

Also, how about other xen-related
devices which are moved to /dev/xen in that same udev rules?

This is the only device currently supported by the vanilla kernel, everything else is in the Xen tree only.

Bastian

Signature · 2 lines
Totally illogical, there was no chance.
		-- Spock, "The Galileo Seven", stardate 2822.3
#8 lore raw

Re: [PATCH] Fix name of Xen event-channel device

Quoted 25 lines · Bastian Blank
Quoted 12 lines · Michael Tokarev
Quoted 11 lines · Bastian Blank

The Xen event-channel device is named evtchn in the kernel but always used as /dev/xen/evtchn in userspace. This patch fixes the name.

drivers/xen/evtchn.c +0 -0
index 66e185c..89cd743 100644
@@ -471,7 +471,7 @@ static const struct file_operations evtchn_fops = {
 
Quoted 7 lines

drivers/xen/evtchn.c static const struct file_operations evtchn_fops = { · line 474

Quoted 4 lines
drivers/xen/evtchn.c +1 -1
  static struct miscdevice evtchn_miscdev = {
     .minor        = MISC_DYNAMIC_MINOR,
-   .name         = "evtchn",
+   .name         = "xen/evtchn",

Um.  Will existing userspace - esp. udev rules - continue to work after this change?

The udev rules will just not longer match, as they only rename the device, this is no problem. However libxc _will_ break, as it lacks proper error check in its own device creation routine.

Quoted 8 lines

However there are not much possibilities here: this support will go away and it will annoy every user for some time.

Quoted 2 lines

                            Also, how about other xen-related devices which are moved to /dev/xen in that same udev rules?

This is the only device currently supported by the vanilla kernel, everything else is in the Xen tree only.

And naming of primary device nodes is no longer udev's task. All these rules are removed from the default udev rules. These names must all come from the kernel these days. Udev will log errors if udev rules specify names which are not in sync with the kernel, so they can be fixed in the kernel or in the rules.

With devtmpfs the kernel needs to know all the names to create them on its own. Udev only manages permissions, possibly creates additional symlinks, runs programs, and distribute the events to userspace. Udev no longer manages the naming of any primary device node.

Thanks,
Kay

#9 lore raw

Re: [PATCH] Fix name of Xen event-channel device

Quoted 1 line · Kay Sievers

On Thu, May 27, 2010 at 19:13, Bastian Blank <[email protected]> wrote:

[]

Quoted 10 lines
Quoted 4 lines
Quoted 2 lines

Also, how about other xen-related
devices which are moved to /dev/xen in that same udev rules?

This is the only device currently supported by the vanilla kernel, everything else is in the Xen tree only.

And naming of primary device nodes is no longer udev's task. All these rules are removed from the default udev rules. These names must all come from the kernel these days. Udev will log errors if udev rules specify names which are not in sync with the kernel, so they can be fixed in the kernel or in the rules.

Finally!... It's been hashed and rehashed back when udevd were invented to replace devfs and we returned back to traditional kernel-generated names for a base. Oh well...

That's, actually, _excellent_ news, something that bothered me for all these years since 2.4 kernel - that I don't have some devices in /dev (because they're named differently or moved to a subdir) which are mentioned in dmesg or sysfs. Hooray!

Will check for all sound (/dev/snd/), input (/dev/input/), usb (/dev/usb/) and oh, the famous tun (/dev/net/tun) devices - you intrigued me!.. ;)

Thanks!

/mjt

#10 lore raw

Re: [PATCH] Fix name of Xen event-channel device

In reply to Bastian Blank
Quoted 4 lines · Bastian Blank

The udev rules will just not longer match, as they only rename the device, this is no problem. However libxc _will_ break, as it lacks proper error check in its own device creation routine.

Yeah, that's really annoying. I can't change the kernel without also having a flag day to update libxc. I guess we could make sure all the stable Xen branches get a libxc fix backported to them, but I wonder if it would break other toolstacks?

Quoted 3 lines

However there are not much possibilities here: this support will go away and it will annoy every user for some time.

But if we don't make any kernel changes then libxc will muddle on even if udev stops handling the device name properly?

J

#11 lore raw
In reply to Bastian Blank
Quoted 11 lines · Bastian Blank
Quoted 7 lines · Bastian Blank
Quoted 2 lines · Bastian Blank

- Make the kernel name the device "xen/evtchn".

This approach somewhat reliable failed for me[1]. Also nothing else in the kernel uses it. So I assume this is not really supported.

Xen themself is responsible for this behaviour.

You presumably don't mean the hypervisor. Do you mean the toolstack is doing something bad when the misc device has a '/' in it? I noticed when I applied your change it does things like look in /sys/class/xen/evtchn (or something).

What other changes are needed to keep things working after this change?

J

#12 lore raw
Quoted 3 lines · Jeremy Fitzhardinge
Quoted 1 line · Bastian Blank

Xen themself is responsible for this behaviour.

You presumably don't mean the hypervisor.

No. But Xen as delivered == hypervisor + tools.

Quoted 4 lines

Do you mean the toolstack is
doing something bad when the misc device has a '/' in it? I noticed when I applied your change it does things like look in /sys/class/xen/evtchn (or something).

It does the following:
- Search in /sys/**/evtchn for the device number, this fails.
- Compares the existing /dev/xen/evtchn with the error and unlinks it.
- Tries to mknod it again with the error value, this fails.

Quoted 1 line

What other changes are needed to keep things working after this change?

To possibilities:
- Fix the error detection in this crude device creation code.
- Rip it out and always rely on the system to provide the devices.

For Debian I already decided to use the later one.

Bastian

Signature · 1 line
We'll pivot at warp 2 and bring all tubes to bear, Mr. Sulu!
#13 lore raw
Quoted 5 lines · Bastian Blank

It does the following:
- Search in /sys/**/evtchn for the device number, this fails.
- Compares the existing /dev/xen/evtchn with the error and unlinks it.
- Tries to mknod it again with the error value, this fails.

That's unfortunate.

Quoted 8 lines
Quoted 2 lines

What other changes are needed to keep things working after this change?

To possibilities:
- Fix the error detection in this crude device creation code.
- Rip it out and always rely on the system to provide the devices.

For Debian I already decided to use the later one.

Yes, that seems like the cleanest approach. Does it need any udev config to get that right? In particular, is there a mechanism to autoload misc device modules?

J

#14 lore raw
Quoted 8 lines · Jeremy Fitzhardinge
Quoted 4 lines · Bastian Blank

To possibilities:
- Fix the error detection in this crude device creation code.
- Rip it out and always rely on the system to provide the devices. For Debian I already decided to use the later one.

Yes, that seems like the cleanest approach. Does it need any udev config to get that right? In particular, is there a mechanism to autoload misc device modules?

No, there is no autoloading possible; neither now nor with the patch. The default udev config is correct in this case.

Bastian

Signature · 1 line
Warp 7 -- It's a law we can live with.