Skip to contentSkip to conversation

writeback: fix non-integrity write-back

PATCH In review Artem Bityutskiy 2 participants 2 messages May 26, 2010 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 writeback: fix non-integrity write-back

From: Artem Bityutskiy <[email protected]>

This is a fix for commit 7c8a3554. Note, I only compile-tested this.

---
 fs/fs-writeback.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/fs-writeback.c +1 -1
index ea8592b..0242855 100644
@@ -920,7 +920,7 @@ long wb_do_writeback(struct bdi_writeback *wb, int force_wait)
 		if (force_wait)
 			work->args.sync_mode = args.sync_mode = WB_SYNC_ALL;
 
-		post_clear = WB_SYNC_ALL || args.sb_pinned;
+		post_clear = args.sync_mode == WB_SYNC_ALL || args.sb_pinned;
 
 		/*
 		 * If this isn't a data integrity operation, just notify
Signature · 1 line
1.6.6.1
#1 lore raw
Quoted 15 lines · Artem Bityutskiy

From: Artem Bityutskiy <[email protected]>

This is a fix for commit 7c8a3554. Note, I only compile-tested this.

---
 fs/fs-writeback.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/fs-writeback.c +0 -0
index ea8592b..0242855 100644

fs/fs-writeback.c long wb_do_writeback(struct bdi_writeback *wb, int force_wait) · line 926

Quoted 8 lines
fs/fs-writeback.c +1 -1
@@ -920,7 +920,7 @@ long wb_do_writeback(struct bdi_writeback *wb, int force_wait)
 		if (force_wait)
 			work->args.sync_mode = args.sync_mode = WB_SYNC_ALL;
 
-		post_clear = WB_SYNC_ALL || args.sb_pinned;
+		post_clear = args.sync_mode == WB_SYNC_ALL || args.sb_pinned;
 
 		/*
 		 * If this isn't a data integrity operation, just notify

Auch, indeed that's a dumb bug. It wont have a huge effect, but it'll serialize some operations that need not be.

I'll queue it up, with the issue that Christoph reported as well, then both of these want to go upstream soon.

Signature · 1 line
Jens Axboe