wireless:ath9k Fix ath_print in xmit.c
PATCH 1/1 wireless:ath9k Fix ath_print in xmit.c
ath_print in xmit.c should say "Reseting hardware" instead of Reaseting HAL!(since HAL is being fazed out). dmesg shows:
[ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last frame [ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!
--- drivers/net/wireless/ath/ath9k/xmit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/ath/ath9k/xmit.c +1 -1
@@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx)int r;ath_print (common,ATH_DBG_FATAL , -"Unable to stop TxDMA. Reset HAL!\n" ); +"Unable to stop TxDMA. Reseting hardware!\n" );spin_lock_bh (&sc->sc_resetlock); r =ath9k_hw_reset (ah, sc->sc_ah->curchan, false);
Signature · 1 line
1.6.5.GIT
Quoted 18 lines · Justin P. Mattock
ath_printinxmit.cshould say "Reseting hardware" instead of Reaseting HAL!(since HAL is being fazed out). dmesg shows:[ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last frame [ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!?Signed-off-by: Justin P. Mattock <[email protected]>
---
?drivers/net/wireless/ath/ath9k/xmit.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)drivers/net/wireless/ath/ath9k/xmit.c +0
-0
drivers/net/wireless/ath/ath9k/xmit.c void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx) · line 1201
Quoted 5 lines
drivers/net/wireless/ath/ath9k/xmit.c +1
-1@@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx) ? ? ? ? ? ? ? ?int r; ? ? ? ? ? ? ? ?ath_print(common, ATH_DBG_FATAL, - ? ? ? ? ? ? ? ? ? ? ? ? "Unable to stop TxDMA. Reset HAL!\n"); + ? ? ? ? ? ? ? ? ? ? ? ? "Unable to stop TxDMA. Reseting hardware!\n");
Thanks for the patch but you need to send this to John, cc linux-wireless.
Luis
Quoted 23 lines · Luis R. Rodriguez
Quoted 20 lines · Justin P. Mattock
ath_printinxmit.cshould say "Reseting hardware" instead of Reaseting HAL!(since HAL is being fazed out). dmesg shows:[ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last frame [ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!Signed-off-by Justin P. Mattock<[email protected]>--- drivers/net/wireless/ath/ath9k/xmit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/net/wireless/ath/ath9k/xmit.c +0
-0@@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx)int r;
Quoted 9 lines
drivers/net/wireless/ath/ath9k/xmit.c void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx) · line 1202
Quoted 4 lines
drivers/net/wireless/ath/ath9k/xmit.c +1
-1ath_print (common,ATH_DBG_FATAL , -"Unable to stop TxDMA. Reset HAL!\n" ); +"Unable to stop TxDMA. Reseting hardware!\n" );Thanks for the patch but you need to send this to John, cc linux-wireless.
Luis
I'll resend with the proper Cc's
Justin P. mattock
Quoted 23 lines · Luis R. Rodriguez
Quoted 20 lines · Justin P. Mattock
ath_printinxmit.cshould say "Reseting hardware" instead of Reaseting HAL!(since HAL is being fazed out). dmesg shows:[ 8660.899624] ath: Failed to stop TX DMA in 100 msec after killing last frame [ 8660.899676] ath: Unable to stop TxDMA. Reset HAL!Signed-off-by Justin P. Mattock<[email protected]>--- drivers/net/wireless/ath/ath9k/xmit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/net/wireless/ath/ath9k/xmit.c +0
-0@@ -1198,7 +1198,7 @@ void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx)int r;
Quoted 9 lines
drivers/net/wireless/ath/ath9k/xmit.c void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx) · line 1202
Quoted 4 lines
drivers/net/wireless/ath/ath9k/xmit.c +1
-1ath_print (common,ATH_DBG_FATAL , -"Unable to stop TxDMA. Reset HAL!\n" ); +"Unable to stop TxDMA. Reseting hardware!\n" );Thanks for the patch but you need to send this to John, cc linux-wireless.
Luis
alright resent with the other patch I had kicking around.. (hopefully the right Cc's)
cheers,
Justin P. Mattock
Quoted 1 line · Justin P. Mattock
ath_printinxmit.cshould say "Reseting hardware"
I think that should be "Resetting hardware" with two t:s.
//Peter
Quoted 10 lines · Peter Stuge
Quoted 2 lines · Justin P. Mattock
ath_printinxmit.cshould say "Reseting hardware"I think that should be "Resetting hardware" with two t:s.
//Peter
yep!!
here is the updated version..
http://thread.gmane.org/gmane.linux.kernel.wireless.general
(duh!! I didn't even think about that)
Thanks for the response.
Justin P. Mattock
Oops.. should be:
http://thread.gmane.org/gmane.linux.kernel.wireless.general/51431
Justin P. Mattock
drivers/net/wireless/ath/ath9k/xmit.c void ath_drain_all_txq(struct ath_softc *sc, bool retry_tx) · line 1201
Quoted 2 lines
drivers/net/wireless/ath/ath9k/xmit.c +1
-1- "Unable to stop TxDMA. Reset HAL!\n"); + "Unable to stop TxDMA. Reseting hardware!\n");
I hate to mention it but the correct spelling is "resetting."
Signature · 2 lines
Roland Dreier <[email protected]> || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html
Quoted 5 lines · Roland Dreier
Quoted 2 lines
- "Unable to stop TxDMA. Reset HAL!\n");
+ "Unable to stop TxDMA. Reseting hardware!\n");I hate to mention it but the correct spelling is "resetting."
no.. mention it!!
anyways the resend is here:
http://thread.gmane.org/gmane.linux.kernel.wireless.general/51431
Justin P. Mattock