Skip to contentSkip to conversation

: i915: Fix missing linux/types.h warning in header

PATCH In review Prarit Bhargava 2 participants 3 messages May 27, 2010 DRM drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : i915: Fix missing linux/types.h warning in header

Fixes warning:

/usr/include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type without #include <linux/types.h>

include/drm/i915_drm.h +1 -0
index b64a8d7..5cf7f5b 100644
@@ -27,6 +27,7 @@
 #ifndef _I915_DRM_H_
 #define _I915_DRM_H_
 
+#include <linux/types.h>
 #include "drm.h"
 
 /* Please note that modifications to all structs defined here are
#1 lore raw
Quoted 11 lines · Prarit Bhargava

Fixes warning:

/usr/include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type without #include <linux/types.h>

include/drm/i915_drm.h +0 -0
index b64a8d7..5cf7f5b 100644

include/drm/i915_drm.h line 31

Quoted 5 lines
include/drm/i915_drm.h +1 -0
@@ -27,6 +27,7 @@
 #ifndef _I915_DRM_H_
 #define _I915_DRM_H_
 
+#include <linux/types.h>
 #include "drm.h"

drm.h includes it, safely tucked inside #ifdef __linux__ so it won't break BSD & OpenSolaris DRI builds - isn't that good enough?

Signature · 2 lines
	-Alan Coopersmith-        [email protected]
	 Oracle Solaris Platform Engineering: X Window System
#2 lore raw
Quoted 17 lines
Quoted 14 lines · Prarit Bhargava

Fixes warning:

/usr/include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type without #include<linux/types.h>

include/drm/i915_drm.h +0 -0
index b64a8d7..5cf7f5b 100644
@@ -27,6 +27,7 @@
  #ifndef _I915_DRM_H_
  #define _I915_DRM_H_
 
Quoted 6 lines

include/drm/i915_drm.h line 32

Quoted 3 lines
include/drm/i915_drm.h +1 -0
+#include<linux/types.h>
  #include "drm.h"
 

drm.h includes it, safely tucked inside #ifdef __linux__ so it won't break BSD& OpenSolaris DRI builds - isn't that good enough?

Hmm ... it doesn't appear to be :/ From a week-old compile of linux-next

/home/linux-next/usr/include/drm/drm_mode.h:84: found __[us]{8,16,32,64} type without #include <linux/types.h> /home/linux-next/usr/include/drm/i915_drm.h:119: found __[us]{8,16,32,64} type without #include <linux/types.h> /home/linux-next/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h> /home/linux-next/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h> /home/linux-next/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>

It could certainly be that the error check is busted ...

P.

Quoted 1 line