Skip to contentSkip to conversation

: i915: fix uninitialized variable warning in i915_setup_compression()

PATCH Applied Prarit Bhargava 2 participants 2 messages May 27, 2010 – Jul 1, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : i915: fix uninitialized variable warning in i915_setup_compression()

Fixes:

drivers/gpu/drm/i915/i915_dma.c: In function ‘i915_setup_compression’:
drivers/gpu/drm/i915/i915_dma.c:1311: error: ‘compressed_llb’ may be used uninitialized in this function

drivers/gpu/drm/i915/i915_dma.c +1 -1
index 4c03ee5..e6a63d1 100644
@@ -1308,7 +1308,7 @@ static void i915_warn_stolen(struct drm_device *dev)
 static void i915_setup_compression(struct drm_device *dev, int size)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;
-	struct drm_mm_node *compressed_fb, *compressed_llb;
+	struct drm_mm_node *compressed_fb, *uninitialized_var(compressed_llb);
 	unsigned long cfb_base;
 	unsigned long ll_base = 0;
 

------------------------------------------------------------------------------

--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Applied
#1 lore raw
Quoted 12 lines · Prarit Bhargava

Fixes:

drivers/gpu/drm/i915/i915_dma.c: In function ‘i915_setup_compression’:
drivers/gpu/drm/i915/i915_dma.c:1311: error: ‘compressed_llb’ may be used uninitialized in this function

drivers/gpu/drm/i915/i915_dma.c +0 -0
index 4c03ee5..e6a63d1 100644

drivers/gpu/drm/i915/i915_dma.c static void i915_warn_stolen(struct drm_device *dev) · line 1313

Quoted 7 lines
drivers/gpu/drm/i915/i915_dma.c +1 -1
@@ -1308,7 +1308,7 @@ static void i915_warn_stolen(struct drm_device *dev)
 static void i915_setup_compression(struct drm_device *dev, int size)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;
-	struct drm_mm_node *compressed_fb, *compressed_llb;
+	struct drm_mm_node *compressed_fb, *uninitialized_var(compressed_llb);
 	unsigned long cfb_base;
 	unsigned long ll_base = 0;

Applied to for-linus. Thanks!

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first

--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel