Skip to contentSkip to conversation

ARM: S5PV210: Add OneNAND device to the GONI board

PATCH New Joonyoung Shim 3 participants 3 messages May 28, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: S5PV210: Add OneNAND device to the GONI board

This patch is to support OneNAND device to the GONI board.

---
 arch/arm/mach-s5pv210/Kconfig     |    1 +
 arch/arm/mach-s5pv210/mach-goni.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/mach-s5pv210/Kconfig +1 -0
index 0761eac..d0432c6 100644
@@ -58,6 +58,7 @@ config MACH_GONI
 	bool "GONI"
 	select CPU_S5PV210
 	select ARCH_SPARSEMEM_ENABLE
+	select S5PC110_DEV_ONENAND
 	help
 	  Machine support for Samsung GONI board
 	  S5PC110(MCP) is one of package option of S5PV210
arch/arm/mach-s5pv210/mach-goni.c +1 -0
index 4863b13..bea812f 100644
@@ -72,6 +72,7 @@ static struct s3c2410_uartcfg goni_uartcfgs[] __initdata = {
 };
 
 static struct platform_device *goni_devices[] __initdata = {
+	&s5pc110_device_onenand,
 };
 
 static void __init goni_map_io(void)
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/2 ARM: S5PV210: Add OneNAND device to the GONI board

Quoted 4 lines · Joonyoung Shim

This patch is to support OneNAND device to the GONI board.

i'd say the second signoff here is at best un-necessary as Joonyoung is the sender of the patch and at worst incorrect.

there's acked-by or other tags for people who've reviewed or tested the patch.

Quoted 31 lines
---
 arch/arm/mach-s5pv210/Kconfig     |    1 +
 arch/arm/mach-s5pv210/mach-goni.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/mach-s5pv210/Kconfig +1 -0
index 0761eac..d0432c6 100644
@@ -58,6 +58,7 @@ config MACH_GONI
 	bool "GONI"
 	select CPU_S5PV210
 	select ARCH_SPARSEMEM_ENABLE
+	select S5PC110_DEV_ONENAND
 	help
 	  Machine support for Samsung GONI board
 	  S5PC110(MCP) is one of package option of S5PV210
arch/arm/mach-s5pv210/mach-goni.c +1 -0
index 4863b13..bea812f 100644
@@ -72,6 +72,7 @@ static struct s3c2410_uartcfg goni_uartcfgs[] __initdata = {
 };
 
 static struct platform_device *goni_devices[] __initdata = {
+	&s5pc110_device_onenand,
 };
 
 static void __init goni_map_io(void)
Signature · 1 line
1.7.0.4
Signature · 5 lines
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.
#2 lore raw

PATCH 1/2 ARM: S5PV210: Add OneNAND device to the GONI board

Quoted 11 lines · Ben Dooks
Quoted 4 lines · Joonyoung Shim

This patch is to support OneNAND device to the GONI board.

i'd say the second signoff here is at best un-necessary as Joonyoung is the sender of the patch and at worst incorrect.

there's acked-by or other tags for people who've reviewed or tested the patch.

it's already discussed. now we got the internal tree and go to mainline. do you mean I send the patch instead of each developers?

Thank you,
Kyungmin Park

Quoted 41 lines
Quoted 31 lines

---
?arch/arm/mach-s5pv210/Kconfig ? ? | ? ?1 +
?arch/arm/mach-s5pv210/mach-goni.c | ? ?1 +
?2 files changed, 2 insertions(+), 0 deletions(-)

arch/arm/mach-s5pv210/Kconfig +0 -0
index 0761eac..d0432c6 100644
@@ -58,6 +58,7 @@ config MACH_GONI

? ? ? bool "GONI"
? ? ? select CPU_S5PV210
? ? ? select ARCH_SPARSEMEM_ENABLE
+ ? ? select S5PC110_DEV_ONENAND
? ? ? help
? ? ? ? Machine support for Samsung GONI board ? ? ? ? S5PC110(MCP) is one of package option of S5PV210

arch/arm/mach-s5pv210/mach-goni.c +1 -1
index 4863b13..bea812f 100644
@@ -72,6 +72,7 @@ static struct s3c2410_uartcfg goni_uartcfgs[] __initdata = {
 ?};
 
 ?static struct platform_device *goni_devices[] __initdata = {
+ ? ? &s5pc110_device_onenand,
 ?};
 
 ?static void __init goni_map_io(void)
--
Quoted 1 line

1.7.0.4

--
--
Ben

Q: ? ? ?What's a light-year?
A: ? ? ?One-third less calories than a regular year.