Skip to contentSkip to conversation

musicpal: Drop redundant reset call

PATCH Applied Jan Kiszka 2 participants 2 messages May 13, 2010 – May 28, 2010

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 musicpal: Drop redundant reset call

Reset is now triggered after init, no need for explicit calls anymore.

---
 hw/musicpal.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
hw/musicpal.c +0 -2
index ebd933e..d44c5a0 100644
@@ -1295,8 +1295,6 @@ static int musicpal_gpio_init(SysBusDevice *dev)
                                        musicpal_gpio_writefn, s);
     sysbus_init_mmio(dev, MP_GPIO_SIZE, iomemtype);
 
-    musicpal_gpio_reset(&dev->qdev);
-
     qdev_init_gpio_out(&dev->qdev, s->out, ARRAY_SIZE(s->out));
 
     qdev_init_gpio_in(&dev->qdev, musicpal_gpio_pin_event, 32);
Signature · 1 line
1.6.0.2
#1 lore raw
Quoted 1 line · Jan Kiszka

Reset is now triggered after init, no need for explicit calls anymore.

Thanks, applied.

Quoted 21 lines
---
 hw/musicpal.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
hw/musicpal.c +0 -2
index ebd933e..d44c5a0 100644
@@ -1295,8 +1295,6 @@ static int musicpal_gpio_init(SysBusDevice *dev)
                                        musicpal_gpio_writefn, s);
     sysbus_init_mmio(dev, MP_GPIO_SIZE, iomemtype);
 
-    musicpal_gpio_reset(&dev->qdev);
-
     qdev_init_gpio_out(&dev->qdev, s->out, ARRAY_SIZE(s->out));
 
     qdev_init_gpio_in(&dev->qdev, musicpal_gpio_pin_event, 32);
Signature · 1 line
1.6.0.2
Signature · 2 lines
Aurelien Jarno                          GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net