Skip to contentSkip to conversation

atl1c: Add AR8151 v2 support and change L0s/L1 routine

PATCH In review [email protected] 2 participants 2 messages May 28, 2010 – May 29, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 atl1c: Add AR8151 v2 support and change L0s/L1 routine

From: [email protected]

Add AR8151 v2.0 Gigabit 1000 support
Change jumbo frame size to 6K
Update L0s/L1 rountine
Update atl1c_suspend routine.

Signed-off-by [email protected]
---
 drivers/net/atl1c/atl1c.h      |    9 +-
 drivers/net/atl1c/atl1c_hw.c   |  107 +++++++++++--
 drivers/net/atl1c/atl1c_hw.h   |   49 ++++++-
 drivers/net/atl1c/atl1c_main.c |  348 +++++++++++++++++++++++-----------------
 4 files changed, 345 insertions(+), 168 deletions(-)
drivers/net/atl1c/atl1c.h +7 -2
index 84ae905..52abbbd 100644
@@ -73,7 +73,8 @@
 #define FULL_DUPLEX        2
 
 #define AT_RX_BUF_SIZE		(ETH_FRAME_LEN + VLAN_HLEN + ETH_FCS_LEN)
-#define MAX_JUMBO_FRAME_SIZE 	(9*1024)
+#define MAX_JUMBO_FRAME_SIZE	(6*1024)
+#define MAX_TSO_FRAME_SIZE      (7*1024)
 #define MAX_TX_OFFLOAD_THRESH	(9*1024)
 
 #define AT_MAX_RECEIVE_QUEUE    4
@@ -87,10 +88,11 @@
 #define AT_MAX_INT_WORK		5
 #define AT_TWSI_EEPROM_TIMEOUT 	100
 #define AT_HW_MAX_IDLE_DELAY 	10
-#define AT_SUSPEND_LINK_TIMEOUT 28
+#define AT_SUSPEND_LINK_TIMEOUT 100
 
 #define AT_ASPM_L0S_TIMER	6
 #define AT_ASPM_L1_TIMER	12
+#define AT_LCKDET_TIMER		12
 
 #define ATL1C_PCIE_L0S_L1_DISABLE 	0x01
 #define ATL1C_PCIE_PHY_RESET		0x02
@@ -316,6 +318,7 @@ enum atl1c_nic_type {
 	athr_l2c_b,
 	athr_l2c_b2,
 	athr_l1d,
+	athr_l1d_2,
 };
 
 enum atl1c_trans_queue {
@@ -392,6 +395,8 @@ struct atl1c_hw {
 	u16 subsystem_id;
 	u16 subsystem_vendor_id;
 	u8 revision_id;
+	u16 phy_id1;
+	u16 phy_id2;
 
 	u32 intr_mask;
 	u8 dmaw_dly_cnt;
drivers/net/atl1c/atl1c_hw.c +92 -15

159 lines not on this page · raw message

drivers/net/atl1c/atl1c_hw.h +46 -3

107 lines not on this page · raw message

drivers/net/atl1c/atl1c_main.c +200 -148

638 lines not on this page · raw message

maintainer
#1 lore raw

From: <[email protected]>
Date: Fri, 28 May 2010 15:40:38 +0800

Quoted 8 lines

From: [email protected]

Add AR8151 v2.0 Gigabit 1000 support
Change jumbo frame size to 6K
Update L0s/L1 rountine
Update atl1c_suspend routine.

Signed-off-by [email protected]

Your commit log message is way too terse.

You should describe in detail what your changes are.

Saying "Update L0s/L1 routine" doesn't tell us exactly what change you are making. And more importantly, it does not tell us why you are making this change.

This also applied to "update atl1c_suspend routine" You have to list exactly change you are making, and why.

You should be able to write a full paragraph explaining what each change is, and the reason for that change. This means 4 to 5 full english sentences, which means more than 3 or 4 words in each sentence.

Do not try to put as minimal amount of information into your commit messages as possible, instead strive to put too much information. Be long winded, and verbose, because you cannot predict what details of your change and reasoning will be important to someone in the future.

Because some day someone will read your commit patch and wonder the reasons why you made your changes.

I am not applying this patch until the commit message is made more verbose and reasonable.