nobh mount option in ext3/4?
ext3 and ext4 heave inherited the nobh option from ext2, but the implementation is rather interesting. Except for the usual option parsing / display it's only respected in ext3_writeback_writepage/ext4_writepage and the truncate_page implementation. Given that we don't take any more than usual care to not create buffers heads during read this is not going to effect a whole lot.
Is there a good reason to keep these options and the associated code complexity? I'd be rather surprised if it gets any sufficient testing..
Jan Kara
reviewerQuoted 11 lines · Christoph Hellwig
ext3 and ext4 heave inherited the nobh option from ext2, but the implementation is rather interesting. Except for the usual option parsing / display it's only respected in ext3_writeback_writepage/ext4_writepage and the
truncate_pageimplementation. Given that we don't take any more than usual care to not create buffers heads during read this is not going to effect a whole lot.Is there a good reason to keep these options and the associated code complexity? I'd be rather surprised if it gets any sufficient testing..
IMHO nobh can go away from ext3/ext4. I would be also in favor of
removing all the nobh logic from VFS and ext2 but for ext2 it saves some low memory so some people might actually use it.
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 1 line · Jan Kara
IMHO nobh can go away from ext3/ext4.
I'll send patches.
Quoted 3 lines
I would be also in favor of
removing all the nobh logic from VFS and ext2 but for ext2 it saves some low memory so some people might actually use it.
I agree that we should get rid of it entirely, but that's the next step.