Skip to contentSkip to conversation

caif: remove unneeded variable from caif_net_open()

PATCH Applied Dan Carpenter 4 participants 5 messages Jun 1, 2010 – Jun 2, 2010

Subsystems (3)
Networking Network drivers Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/2 caif: remove unneeded variable from caif_net_open()

We don't use the "ser" variable so I've removed it.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/caif/caif_serial.c +0 -2
index 09257ca..f30a6a0 100644
@@ -410,8 +410,6 @@ static void caifdev_setup(struct net_device *dev)
 
 static int caif_net_open(struct net_device *dev)
 {
-	struct ser_device *ser;
-	ser = netdev_priv(dev);
 	netif_wake_queue(dev);
 	return 0;
 }
#2 lore raw
In reply to Dan Carpenter
Quoted 9 lines · Dan Carpenter

We don't use the "ser" variable so I've removed it.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/caif/caif_serial.c +0 -0
index 09257ca..f30a6a0 100644

drivers/net/caif/caif_serial.c static void caifdev_setup(struct net_device *dev) · line 415

Quoted 8 lines
drivers/net/caif/caif_serial.c +0 -2
@@ -410,8 +410,6 @@ static void caifdev_setup(struct net_device *dev)
 
 static int caif_net_open(struct net_device *dev)
 {
-	struct ser_device *ser;
-	ser = netdev_priv(dev);
 	netif_wake_queue(dev);
 	return 0;
 }

what makes caif_net_open() obsolet ?

re,
wh

author
#3 lore raw
Quoted 11 lines · walter harms

drivers/net/caif/caif_serial.c static void caifdev_setup(struct net_device *dev) · line 415

Quoted 7 lines

static int caif_net_open(struct net_device *dev)
{

drivers/net/caif/caif_serial.c +0 -2
-	struct ser_device *ser;
-	ser = netdev_priv(dev);
 	netif_wake_queue(dev);
 	return 0;
 }

what makes caif_net_open() obsolet ?

No. It has to return an int to match this:

        int                     (*ndo_open)(struct net_device *dev);

regards,
dan carpenter