Skip to contentSkip to conversation

ppp: eliminate shadowed variable name

PATCH Applied Stephen Hemminger 2 participants 2 messages Jun 1, 2010 – Jun 2, 2010

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

PATCH 1/1 ppp: eliminate shadowed variable name

Sparse complains about shadowed declaration of skb. So use other name.

Signed-off-by Stephen Hemminger <[email protected]>
drivers/net/ppp_generic.c +3 -3
@@ -1927,9 +1927,9 @@ ppp_receive_mp_frame(struct ppp *ppp, st
 	/* If the queue is getting long, don't wait any longer for packets
 	   before the start of the queue. */
 	if (skb_queue_len(&ppp->mrq) >= PPP_MP_MAX_QLEN) {
-		struct sk_buff *skb = skb_peek(&ppp->mrq);
-		if (seq_before(ppp->minseq, skb->sequence))
-			ppp->minseq = skb->sequence;
+		struct sk_buff *mskb = skb_peek(&ppp->mrq);
+		if (seq_before(ppp->minseq, mskb->sequence))
+			ppp->minseq = mskb->sequence;
 	}
 
 	/* Pull completed packets off the queue and receive them. */