Skip to contentSkip to conversation

nfsd: nfsd_setattr needs to call commit_metadata

PATCH In review Christoph Hellwig 2 participants 2 messages Jun 1, 2010

Subsystems (2)
NFS client NFS server
lore
Share & tools
lore

Christoph Hellwig

author
#0 lore raw

PATCH 1/1 nfsd: nfsd_setattr needs to call commit_metadata

The conversion of write_inode_now calls to commit_metadata in commit f501912a35c02eadc55ca9396ece55fe36f785d0 missed out the call in nfsd_setattr.

But without this conversion we can't guarantee that a SETATTR request has actually been commited to disk with XFS, which causes a regression from 2.6.32 (only for NFSv2, but anyway).

Signed-off-by Christoph Hellwig <[email protected]>
fs/nfsd/vfs.c +1 -2
Index: linux-2.6/fs/nfsd/vfs.c
===================================================================
@@ -443,8 +443,7 @@ nfsd_setattr(struct svc_rqst *rqstp, str
 	if (size_change)
 		put_write_access(inode);
 	if (!err)
-		if (EX_ISSYNC(fhp->fh_export))
-			write_inode_now(inode, 1);
+		commit_metadata(fhp);
 out:
 	return err;
#1 lore raw
Quoted 6 lines · Christoph Hellwig

The conversion of write_inode_now calls to commit_metadata in commit f501912a35c02eadc55ca9396ece55fe36f785d0 missed out the call in nfsd_setattr.

But without this conversion we can't guarantee that a SETATTR request has actually been commited to disk with XFS, which causes a regression from 2.6.32 (only for NFSv2, but anyway).

Got it, thanks.

--b.

Quoted 21 lines
Signed-off-by Christoph Hellwig <[email protected]>

Index: linux-2.6/fs/nfsd/vfs.c
===================================================================

fs/nfsd/vfs.c +1 -3
@@ -443,8 +443,7 @@ nfsd_setattr(struct svc_rqst *rqstp, str
 	if (size_change)
 		put_write_access(inode);
 	if (!err)
-		if (EX_ISSYNC(fhp->fh_export))
-			write_inode_now(inode, 1);
+		commit_metadata(fhp);
 out:
 	return err;
 
--

To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html