Skip to contentSkip to conversation

korina: count RX DMA OVR as rx_fifo_error

PATCH Applied Phil Sutter 2 participants 4 messages May 29, 2010 – Jun 2, 2010 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

PATCH 3/3 korina: count RX DMA OVR as rx_fifo_error

This way, RX DMA overruns (actually being caused by overrun of the 512byte input FIFO) show up in ifconfig output. The rx_fifo_errors counter is unused otherwise.

---
 drivers/net/korina.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/korina.c +1 -1
index 3e9b6b7..c7a9bef 100644
@@ -376,7 +376,7 @@ static int korina_rx(struct net_device *dev, int limit)
 		if (devcs & ETH_RX_LE)
 			dev->stats.rx_length_errors++;
 		if (devcs & ETH_RX_OVR)
-			dev->stats.rx_over_errors++;
+			dev->stats.rx_fifo_errors++;
 		if (devcs & ETH_RX_CV)
 			dev->stats.rx_frame_errors++;
 		if (devcs & ETH_RX_CES)
Signature · 1 line
1.6.4.4
maintainer Applied
#3 lore raw

From: Phil Sutter <[email protected]>
Date: Sun, 30 May 2010 01:23:36 +0200

Quoted 5 lines

This way, RX DMA overruns (actually being caused by overrun of the 512byte input FIFO) show up in ifconfig output. The rx_fifo_errors counter is unused otherwise.

Applied.

#4 lore raw

PATCH 2/3 korina: use netdev_alloc_skb_ip_align() here, too

In reply to a message not in the archive

This patch completes commit 89d71a66c40d629e3b1285def543ab1425558cd5 which missed this spot, as it seems.

---
 drivers/net/korina.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/net/korina.c +1 -2
index 13533f9..3e9b6b7 100644
@@ -765,10 +765,9 @@ static int korina_alloc_ring(struct net_device *dev)
 
 	/* Initialize the receive descriptors */
 	for (i = 0; i < KORINA_NUM_RDS; i++) {
-		skb = dev_alloc_skb(KORINA_RBSIZE + 2);
+		skb = netdev_alloc_skb_ip_align(dev, KORINA_RBSIZE);
 		if (!skb)
 			return -ENOMEM;
-		skb_reserve(skb, 2);
 		lp->rx_skb[i] = skb;
 		lp->rd_ring[i].control = DMA_DESC_IOD |
 				DMA_COUNT(KORINA_RBSIZE);
Signature · 1 line
1.6.4.4
maintainer Applied
#5 lore raw

Re: [PATCH 2/3] korina: use netdev_alloc_skb_ip_align() here, too

From: Phil Sutter <[email protected]>
Date: Sun, 30 May 2010 01:23:35 +0200

Quoted 4 lines

This patch completes commit 89d71a66c40d629e3b1285def543ab1425558cd5 which missed this spot, as it seems.

Applied.