Skip to contentSkip to conversation

input: bcm5974 turn wellspring mode off if failed to start traffic

PATCH In review Luo Jinghua 3 participants 3 messages Jun 2, 2010 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 input: bcm5974 turn wellspring mode off if failed to start traffic

The bcm5974 driver doesn't work on my MacbookPro6,2 for some reason. It failed to start traffic and left the wellsprint mode on. As a result, the keyboard is slow to response and become unusable.

---
 drivers/input/mouse/bcm5974.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/input/mouse/bcm5974.c +1 -0
index 6dedded..5518089 100644
@@ -595,6 +595,7 @@ static int bcm5974_start_traffic(struct bcm5974 *dev)
 
 err_kill_bt:
 	usb_kill_urb(dev->bt_urb);
+	bcm5974_wellspring_mode(dev, false);
 error:
 	return -EIO;
 }
Signature · 1 line
1.7.1
maintainer
#1 lore raw

Hi Luo,

Quoted 14 lines · Luo Jinghua

The bcm5974 driver doesn't work on my MacbookPro6,2 for some reason. It failed to start traffic and left the wellsprint mode on. As a result, the keyboard is slow to response and become unusable.

---
 drivers/input/mouse/bcm5974.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/input/mouse/bcm5974.c +0 -0
index 6dedded..5518089 100644

drivers/input/mouse/bcm5974.c static int bcm5974_start_traffic(struct bcm5974 *dev) · line 601

Quoted 7 lines
drivers/input/mouse/bcm5974.c +1 -0
@@ -595,6 +595,7 @@ static int bcm5974_start_traffic(struct bcm5974 *dev)
 
 err_kill_bt:
 	usb_kill_urb(dev->bt_urb);
+	bcm5974_wellspring_mode(dev, false);
 error:
 	return -EIO;
 }

Could you see what URB it failed to submit and what error code was returned? Maybe it will give us idea what went wrong.

Signature · 1 line
Dmitry

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

Luo Jinghua wrote:
[...]

Quoted 1 line

So the error code is the ENOSPC.

Interesting. A couple of years back, there were a few reports on strange usb behavior on Macbooks that turned out to be a hardware problem, a bad internal usb connector. Could that be the case here?

Since ENOSPC is pretty rare, narrowing it down code-wise seems possible. It could for instance be this path happening:

usb_submit_urb
usb_hcd_submit_urb

     hcd->driver->urb_enqueue
       ehci_urb_enqueue
         intr_submit
           qh_schedule
             fail

Henrik