Skip to contentSkip to conversation

e1000e: change logical negate to bitwise

PATCH Applied Jeff Kirsher 2 participants 2 messages Jun 2, 2010 – Jun 3, 2010

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Jeff Kirsher

author
#0 lore raw

PATCH 1/1 e1000e: change logical negate to bitwise

From: Dan Carpenter <[email protected]>

The bitwise negate is intended here. With the logical negate the condition is always false.

Signed-off-by Dan Carpenter <[email protected]>
Acked-by Bruce Allan <[email protected]>
Signed-off-by Jeff Kirsher <[email protected]>

---

 drivers/net/e1000e/netdev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/e1000e/netdev.c +1 -1
index 24507f3..57a7e41 100644
@@ -2554,7 +2554,7 @@ static void e1000_init_manageability_pt(struct e1000_adapter *adapter)
 			mdef = er32(MDEF(i));
 
 			/* Ignore filters with anything other than IPMI ports */
-			if (mdef & !(E1000_MDEF_PORT_623 | E1000_MDEF_PORT_664))
+			if (mdef & ~(E1000_MDEF_PORT_623 | E1000_MDEF_PORT_664))
 				continue;
 
 			/* Enable this decision filter in MANC2H */