Skip to contentSkip to conversation

x86: OLPC: add support for calling into OpenFirmware

PATCH New Andres Salomon 1 participant 1 message Jun 3, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/4 x86: OLPC: add support for calling into OpenFirmware

Add support for saving OFW's cif, and later calling into it to run OFW commands. OFW remains resident in memory, living within virtual range 0xff800000 - 0xffc00000. A single page directory entry points to the pgdir that OFW actually uses, so rather than saving the entire page table, we save that one entry (and restore it for the call into OFW).

This is currently only used by the OLPC XO; however, there's nothing restricting OFW's usage on other (x86) platforms.

---
 arch/x86/Kconfig                        |    9 +++
 arch/x86/include/asm/olpc_ofw.h         |   33 ++++++++++++
 arch/x86/include/asm/pgtable_32_types.h |   14 ++++-
 arch/x86/include/asm/setup.h            |    1 +
 arch/x86/kernel/Makefile                |    1 +
 arch/x86/kernel/head_32.S               |   31 +++++++++++
 arch/x86/kernel/olpc.c                  |    8 ++--
 arch/x86/kernel/olpc_ofw.c              |   88 +++++++++++++++++++++++++++++++
 arch/x86/kernel/setup.c                 |    3 +
 arch/x86/mm/dump_pagetables.c           |    7 +++
 arch/x86/mm/init_32.c                   |   17 ++++++
 11 files changed, 205 insertions(+), 7 deletions(-)
 create mode 100644 arch/x86/include/asm/olpc_ofw.h
 create mode 100644 arch/x86/kernel/olpc_ofw.c
arch/x86/Kconfig +9 -0
index dcb0593..71c194d 100644
@@ -2062,6 +2062,15 @@ config OLPC
 	  Add support for detecting the unique features of the OLPC
 	  XO hardware.
 
+config OLPC_OPENFIRMWARE
+	bool "Support for OLPC's Open Firmware"
+	depends on !X86_64 && !X86_PAE
+	default y if OLPC
+	help
+	  This option adds support for the implementation of Open Firmware
+	  that is used on the OLPC XO-1 Children's Machine.
+	  If unsure, say N here.
+
 endif # X86_32
 
 config K8_NB
arch/x86/include/asm/olpc_ofw.h new file +33 -0
new file mode 100644
index 0000000..9c63649
@@ -0,0 +1,33 @@
+#ifndef _ASM_X86_OLPC_OFW_H
+#define _ASM_X86_OLPC_OFW_H
+
+/* hardcode addresses to make life easier dealing w/ VMALLOC_END and others */
+#define OLPC_OFW_START 0xff800000UL
+#define OLPC_OFW_SIZE (PGDIR_SIZE)
+#define OLPC_OFW_END (OLPC_OFW_START + OLPC_OFW_SIZE)
+
+#ifdef CONFIG_OLPC_OPENFIRMWARE
+
+#ifndef __ASSEMBLER__
+
+/* address of OFW callback interface; will be NULL if OFW isn't found */
+extern int (*olpc_ofw_cif)(int *);
+
+/* page dir entry containing OFW's current memory */
+extern pgdval_t olpc_ofw_pgd;
+
+/* run an OFW command by calling into the firmware */
+extern int olpc_ofw(const char *name, int nr_args, int nr_res, ...);
+
+/* determine/ensure OFW lives in the proper place in (virtual) memory */
+void olpc_ofw_detect_range(void);
+
+#endif
+
+#else
+
+static inline void olpc_ofw_detect_range(void) { }
+
+#endif
+
+#endif
arch/x86/include/asm/pgtable_32_types.h +11 -3
index 5e67c15..5f52bb0 100644
@@ -37,13 +37,21 @@ extern bool __vmalloc_start_set; /* set once high_memory is set */
 #define LAST_PKMAP 1024
 #endif
 
-#define PKMAP_BASE ((FIXADDR_BOOT_START - PAGE_SIZE * (LAST_PKMAP + 1))	\
-		    & PMD_MASK)
+#include <asm/olpc_ofw.h>
+
+/* make sure we have enough space for PKMAP region *and* OFW after VMALLOC*/
+#define PKMAP_BASE ((FIXADDR_BOOT_START - PAGE_SIZE * (LAST_PKMAP + 1) \
+		- OLPC_OFW_SIZE) & PMD_MASK)
 
 #ifdef CONFIG_HIGHMEM
 # define VMALLOC_END	(PKMAP_BASE - 2 * PAGE_SIZE)
 #else
-# define VMALLOC_END	(FIXADDR_START - 2 * PAGE_SIZE)
+# ifdef CONFIG_OLPC_OPENFIRMWARE
+   /* dumppages looks a lot saner if we leave a PGDIR_SIZEd gap */
+#  define VMALLOC_END	(OLPC_OFW_START - PGDIR_SIZE)
+# else
+#  define VMALLOC_END	(FIXADDR_START - 2 * PAGE_SIZE)
+# endif
 #endif
 
 #define MODULES_VADDR	VMALLOC_START
arch/x86/include/asm/setup.h +1 -0
index 86b1506..e78a9b3 100644
@@ -21,6 +21,7 @@
 #define OLD_CL_MAGIC		0xA33F
 #define OLD_CL_ADDRESS		0x020	/* Relative to real mode data */
 #define NEW_CL_POINTER		0x228	/* Relative to real mode data */
+#define OLPC_OFW_INFO_OFFSET	0xb0	/* Relative to real mode data */
 
 #ifndef __ASSEMBLY__
 #include <asm/bootparam.h>
arch/x86/kernel/Makefile +1 -0
index e77b220..0925676 100644
@@ -104,6 +104,7 @@ obj-$(CONFIG_SCx200)		+= scx200.o
 scx200-y			+= scx200_32.o
 
 obj-$(CONFIG_OLPC)		+= olpc.o
+obj-$(CONFIG_OLPC_OPENFIRMWARE)	+= olpc_ofw.o
 obj-$(CONFIG_X86_MRST)		+= mrst.o
 
 microcode-y				:= microcode_core.o
arch/x86/kernel/head_32.S +31 -0
index 37c3d4b..2e3af8b 100644
@@ -131,6 +131,29 @@ ENTRY(startup_32)
 	movsl
 1:
 
+#ifdef CONFIG_OLPC_OPENFIRMWARE
+	movl $0x0, pa(olpc_ofw_cif)
+
+	/* Did OpenFirmware boot us? */
+	movl $pa(boot_params) + OLPC_OFW_INFO_OFFSET, %ebp
+	cmpl $0x2057464F, (%ebp)	/* Magic number "OFW " */
+	jne 3f
+
+	/* Save the callback address for calling into OFW from linux */
+	mov 0x8(%ebp), %eax
+	mov %eax, pa(olpc_ofw_cif)
+
+	/* %cr3 holds OFW's pgdir table.  For calling info OFW, we need to
+	 * the save next-to-last pgdir table entry, which points to a page
+	 * table that lives within OFW's memory.  The pgdir table contains
+	 * 1024 entries (each a 4 byte pde), so we want
+	 * ((int *) %cr3)[1022]. */
+	movl %cr3, %eax
+	movl 1022*4(%eax), %ebx
+	movl %ebx, pa(olpc_ofw_pgd)
+3:
+#endif
+
 #ifdef CONFIG_PARAVIRT
 	/* This is can only trip for a broken bootloader... */
 	cmpw $0x207, pa(boot_params + BP_version)
@@ -658,6 +681,14 @@ ENTRY(stack_start)
 	.long init_thread_union+THREAD_SIZE
 	.long __BOOT_DS
 
+.globl olpc_ofw_cif
+.globl olpc_ofw_pgd
+
+olpc_ofw_cif:
+	.long olpc_ofw_cif
+olpc_ofw_pgd:
+	.long olpc_ofw_pgd
+
 ready:	.byte 0
 
 early_recursion_flag:
arch/x86/kernel/olpc.c +4 -4
index 8297160..c572e9e 100644
@@ -22,8 +22,8 @@
 #include <asm/setup.h>
 #include <asm/olpc.h>
 
-#ifdef CONFIG_OPEN_FIRMWARE
-#include <asm/ofw.h>
+#ifdef CONFIG_OLPC_OPENFIRMWARE
+#include <asm/olpc_ofw.h>
 #endif
 
 struct olpc_platform_t olpc_platform_info;
@@ -188,13 +188,13 @@ err:
 }
 EXPORT_SYMBOL_GPL(olpc_ec_cmd);
 
-#ifdef CONFIG_OPEN_FIRMWARE
+#ifdef CONFIG_OLPC_OPENFIRMWARE
 static void __init platform_detect(void)
 {
 	size_t propsize;
 	__be32 rev;
 
-	if (ofw("getprop", 4, 1, NULL, "board-revision-int", &rev, 4,
+	if (olpc_ofw("getprop", 4, 1, NULL, "board-revision-int", &rev, 4,
 			&propsize) || propsize != 4) {
 		printk(KERN_ERR "ofw: getprop call failed!\n");
 		rev = cpu_to_be32(0);
arch/x86/kernel/olpc_ofw.c new file +88 -0

88 lines not on this page · raw message

arch/x86/kernel/setup.c +3 -0
index b4ae4ac..477440a 100644
@@ -102,6 +102,7 @@
 
 #include <asm/paravirt.h>
 #include <asm/hypervisor.h>
+#include <asm/olpc_ofw.h>
 
 #include <asm/percpu.h>
 #include <asm/topology.h>
@@ -859,6 +860,8 @@ void __init setup_arch(char **cmdline_p)
 
 	dmi_check_system(bad_bios_dmi_table);
 
+	olpc_ofw_detect_range();
+
 	/*
 	 * VMware detection requires dmi to be available, so this
 	 * needs to be done after dmi_scan_machine, for the BP.
arch/x86/mm/dump_pagetables.c +7 -0
index 0002a3a..248f7a7 100644
@@ -18,6 +18,7 @@
 #include <linux/seq_file.h>
 
 #include <asm/pgtable.h>
+#include <asm/olpc_ofw.h>
 
 /*
  * The dumper groups pagetable entries of the same type into one, and for
@@ -55,6 +56,9 @@ enum address_markers_idx {
 # ifdef CONFIG_HIGHMEM
 	PKMAP_BASE_NR,
 # endif
+# ifdef CONFIG_OLPC_OPENFIRMWARE
+	OLPC_OFW_START_NR,
+# endif
 	FIXADDR_START_NR,
 #endif
 };
@@ -77,6 +81,9 @@ static struct addr_marker address_markers[] = {
 # ifdef CONFIG_HIGHMEM
 	{ 0/*PKMAP_BASE*/,      "Persisent kmap() Area" },
 # endif
+# ifdef CONFIG_OLPC_OPENFIRMWARE
+	{ OLPC_OFW_START,	"OpenFirmware Mapping" },
+# endif
 	{ 0/*FIXADDR_START*/,   "Fixmap Area" },
 #endif
 	{ -1, NULL }		/* End of list */
arch/x86/mm/init_32.c +17 -0
index bca7909..f55ec53 100644
@@ -49,6 +49,7 @@
 #include <asm/paravirt.h>
 #include <asm/setup.h>
 #include <asm/cacheflush.h>
+#include <asm/olpc_ofw.h>
 #include <asm/page_types.h>
 #include <asm/init.h>
 
@@ -903,6 +904,9 @@ void __init mem_init(void)
 
 	printk(KERN_INFO "virtual kernel memory layout:\n"
 		"    fixmap  : 0x%08lx - 0x%08lx   (%4ld kB)\n"
+#ifdef CONFIG_OLPC_OPENFIRMWARE
+		"    ofw     : 0x%08lx - 0x%08lx   (%4ld MB)\n"
+#endif
 #ifdef CONFIG_HIGHMEM
 		"    pkmap   : 0x%08lx - 0x%08lx   (%4ld kB)\n"
 #endif
@@ -914,6 +918,12 @@ void __init mem_init(void)
 		FIXADDR_START, FIXADDR_TOP,
 		(FIXADDR_TOP - FIXADDR_START) >> 10,
 
+#ifdef CONFIG_OLPC_OPENFIRMWARE
+		olpc_ofw_cif ? OLPC_OFW_START : 0,
+		olpc_ofw_cif ? OLPC_OFW_END : 0,
+		olpc_ofw_cif ? (OLPC_OFW_END - OLPC_OFW_START) >> 20 : 0,
+#endif
+
 #ifdef CONFIG_HIGHMEM
 		PKMAP_BASE, PKMAP_BASE+LAST_PKMAP*PAGE_SIZE,
 		(LAST_PKMAP*PAGE_SIZE) >> 10,
@@ -941,7 +951,14 @@ void __init mem_init(void)
 	 */
 #define __FIXADDR_TOP (-PAGE_SIZE)
 #ifdef CONFIG_HIGHMEM
+#ifdef CONFIG_OLPC_OPENFIRMWARE
+	BUILD_BUG_ON(PKMAP_BASE + LAST_PKMAP*PAGE_SIZE	> OLPC_OFW_START);
+#else
 	BUILD_BUG_ON(PKMAP_BASE + LAST_PKMAP*PAGE_SIZE	> FIXADDR_START);
+#endif
+#ifdef CONFIG_OLPC_OPENFIRMWARE
+	BUILD_BUG_ON(OLPC_OFW_END			>= FIXADDR_START);
+#endif
 	BUILD_BUG_ON(VMALLOC_END			> PKMAP_BASE);
 #endif
 #define high_memory (-128UL << 20)
Signature · 1 line
1.5.6.5