Skip to contentSkip to conversation

S5PV210: Increase the VIC_NR as 4

PATCH New Kyungmin Park 3 participants 3 messages Jun 3, 2010 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 S5PV210: Increase the VIC_NR as 4

The S5PV210 SoC have 4 VICs. It requires for suspend and resume.

---

arch/arm/common/Kconfig +1 -0
index 0a34c81..0ac3d81 100644
@@ -6,6 +6,7 @@ config ARM_VIC
 
 config ARM_VIC_NR
 	int
+	default 4 if ARCH_S5PV210
 	default 2
 	depends on ARM_VIC
 	help
#1 lore raw

PATCH 1/1 S5PV210: Increase the VIC_NR as 4

Quoted 1 line · Kyungmin Park

The S5PV210 SoC have 4 VICs. It requires for suspend and resume.

Isn't this negated by Ben's "ARM: VIC: Allocate VIC PM device from slab" patch?

Incidentally, shouldn't Ben's patch remove this configuration option too?

Quoted 20 lines

---

arch/arm/common/Kconfig +1 -0
index 0a34c81..0ac3d81 100644
@@ -6,6 +6,7 @@ config ARM_VIC
 
 config ARM_VIC_NR
 	int
+	default 4 if ARCH_S5PV210
 	default 2
 	depends on ARM_VIC
 	help

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw

PATCH 1/1 S5PV210: Increase the VIC_NR as 4

Quoted 5 lines · Russell King - ARM Linux
Quoted 1 line · Kyungmin Park

The S5PV210 SoC have 4 VICs. It requires for suspend and resume.

Isn't this negated by Ben's "ARM: VIC: Allocate VIC PM device from slab" patch?

I was awaiting the feedback from other archs which I don't have access to...

Quoted 1 line

Incidentally, shouldn't Ben's patch remove this configuration option too?

Yes, you're right, should have removed these.

Quoted 20 lines
Quoted 20 lines

---

arch/arm/common/Kconfig +1 -0
index 0a34c81..0ac3d81 100644
@@ -6,6 +6,7 @@ config ARM_VIC
 
 config ARM_VIC_NR
 	int
+	default 4 if ARCH_S5PV210
 	default 2
 	depends on ARM_VIC
 	help

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 5 lines
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.