vt_ioctl: return -EFAULT on copy_from_user errors

PATCH New Dan Carpenter 1 participant 1 message Jun 4, 2010

Subsystems (2)

Kernel janitors Char and misc drivers

lore

Share & tools

lore

Dan Carpenter

author

2010-06-04 10:20 UTC #0 lore raw

PATCH 1/1 vt_ioctl: return -EFAULT on copy_from_user errors

copy_from_user() returns the number of bytes remaining but we want to return a negative error code here.

Signed-off-by Dan Carpenter <[email protected]>

drivers/char/vt_ioctl.c +3 -1

index 6aa1028..cb19dbc 100644
@@ -1303,7 +1303,9 @@ int vt_ioctl(struct tty_struct *tty, struct file * file,
 		if (!perm)
 			goto eperm;
 		ret = copy_from_user(&ui, up, sizeof(struct unimapinit));
-		if (!ret)
+		if (ret)
+			ret = -EFAULT;
+		else
 			con_clear_unimap(vc, &ui);
 		break;
 	      }