drm/drm_crtc: return -EFAULT on copy_to_user errors

PATCH New Dan Carpenter 1 participant 1 message Jun 4, 2010

Subsystems (3)

DRM drivers DRM misc Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2010-06-04 10:23 UTC #0 lore raw

PATCH 1/1 drm/drm_crtc: return -EFAULT on copy_to_user errors

copy_from_user() returns the number of bytes left to be copied but we want to return a negative error code here. This is in the ioctl handler so the error code get returned to userspace.

Signed-off-by Dan Carpenter <[email protected]>

drivers/gpu/drm/drm_crtc.c +3 -1

index 994d23b..57cea01 100644
@@ -1840,8 +1840,10 @@ int drm_mode_dirtyfb_ioctl(struct drm_device *dev,
 
 		ret = copy_from_user(clips, clips_ptr,
 				     num_clips * sizeof(*clips));
-		if (ret)
+		if (ret) {
+			ret = -EFAULT;
 			goto out_err2;
+		}
 	}
 
 	if (fb->funcs->dirty) {